Move Value Mappings to Outside Helm Package #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om file outside of helm package
jddarby
pushed a commit
that referenced
this pull request
Jun 6, 2023
…python (Azure#6144) * changing version number naming scheme and bugfix for 32bit python * addressing PR comments * moving where pulling files happens from * making a sha256 hash of the security policy print out when injecting into arm template * taking out the --json option * removing unused function * adding warnings for save to file and debug mode. fixed bug with numbers for template parameters * taking out unused function and fixing style checks * adding error checking back in for when dmverity-vhd returns nothing * making it so you can disable allow_elevated via the privileged field in the arm template * Feature/security context (#18) * securityContext --------- Co-authored-by: Seth Hollandsworth <seth.hollandsworth@gmail.com> Co-authored-by: Seth Hollandsworth <sethho@microsoft.com> * changing default value of no_new_privileges * updating tests * taking allow_elevated out of expected fields in ARM template * adding docs for dmverity hashing and fixing markdown styling --------- Co-authored-by: Heather Garvison <hgarvison@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added path_to_mappings to input.json; added logic to take mappings from file outside of helm package
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.