v21.5.0 would not work with custom options

[AngusFu]

Description

SEE 8b549da#r39933403

Steps to reproduce

const { Projects } = require('@gitbeaker/node');

const api = new Projects({
  host: 'https://gitlab.XXXXXXX.COM',
  token: 'SOME_TOKEN'
});

console.log(api.url);  // v21.5.0 would still print out "https://gitlab.com/api/v4/"

Possible fixes

Just fix the extendClass function in packages/gitbeaker-requester-utils/src/RequesterUtils.ts

Why

function extendClass<T extends Constructable>(Base: T, customConfig: object): T {Justin Dalrymple, 4 days ago: • Remove Gitlab Instance dependency for CLI tes…
  return class extends Base {
    constructor(...options: any[]) {
      super({ ...options, ...customConfig });
    }
  };
}

Another demo:

function extendClass(Base, customConfig) {
  return class extends Base {
    constructor(...options) {
      super({ ...options, ...customConfig });
    }
  };
}

const Klass = extendClass(
  class Base {
    constructor(config) {
      console.log(config);
      this.host = config.host || 'http://xxxx.yyyy'
    }
  },
  { time: Date.now() }
)

console.log( new Klass({ host: 'https://my.gitlab.com' }) )

[xinchanghao]

😦

[DerPate]

Can confirm the same Problem here.

[jdalrymple]

I'll give it a look! Thanks for the well formed bug report 😍

[jdalrymple]

🚀 Issue was released in 21.7.0 🚀