Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken build due to failed linkcheck job #1974

Closed
atugushev opened this issue Aug 20, 2023 · 1 comment · Fixed by #2042
Closed

Broken build due to failed linkcheck job #1974

atugushev opened this issue Aug 20, 2023 · 1 comment · Fixed by #2042
Labels
bug Something is not working ci Related to continuous integration tasks docs Documentation related good first issue A good item for first time contributors to work on help wanted Request help from the community PR wanted Feature is discussed or bug is confirmed, PR needed

Comments

@atugushev
Copy link
Member

atugushev commented Aug 20, 2023 •
edited
Loading

I've noticed that matrix badges are frequently inaccessible, see README:
image

Sometimes, a certain issue even results in CI builds breaking (caught in #1973):

broken    https://img.shields.io/matrix/pip-tools:matrix.org?label=Discuss%20on%20Matrix%20at%20%23pip-tools%3Amatrix.org&logo=matrix&server_fqdn=matrix.org&style=flat - 408 Client Error: Request Timeout for url: https://img.shields.io/matrix/pip-tools:matrix.org?label=Discuss%20on%20Matrix%20at%20%23pip-tools%3Amatrix.org&logo=matrix&server_fqdn=matrix.org&style=flat

Perhaps we should consider ignoring https://img.shields.io/matrix as well?

/cc @webknjaz
@atugushev atugushev added docs Documentation related bug Something is not working ci Related to continuous integration tasks labels Aug 20, 2023
@webknjaz
Copy link
Member

Yes, that makes sense.

@atugushev atugushev added help wanted Request help from the community good first issue A good item for first time contributors to work on labels Aug 21, 2023
@chrysle chrysle added the PR wanted Feature is discussed or bug is confirmed, PR needed label Oct 11, 2023
@kysre kysre mentioned this issue Jan 5, 2024
Merged
4 tasks
@kysre kysre linked a pull request Jan 5, 2024 that will close this issue
Ignore matrix badges in ci linkcheck-docs #2042
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working ci Related to continuous integration tasks docs Documentation related good first issue A good item for first time contributors to work on help wanted Request help from the community PR wanted Feature is discussed or bug is confirmed, PR needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore matrix badges in ci linkcheck-docs kysre/jazzband-pip-tools
3 participants
@webknjaz @atugushev @chrysle