Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with HMAC algorithms if VERIFYING_KEY is unset, the exp claim is not verified #626

Closed
simevo opened this issue Oct 3, 2022 · 2 comments
Closed

with HMAC algorithms if VERIFYING_KEY is unset, the exp claim is not verified #626

simevo opened this issue Oct 3, 2022 · 2 comments
Assignees
@Andrew-Chen-Wang
Labels
bug

Comments

@simevo
Copy link

simevo commented Oct 3, 2022 •
edited
Loading

in the config, we have ALGORITHM = HS256 and VERIFYING_KEY is None because "If an HMAC algorithm has been specified by the ALGORITHM setting, the VERIFYING_KEY setting will be ignored"

unexpectedly, after upgrading djangorestframework-simplejwt to v5.2.1 the exp claim is not anymore verified: expired tokens are happily accepted

upon investigation, that's because of PR #605

I think this will suprise many people !
@MWGCLB
Copy link

MWGCLB commented Oct 7, 2022

It surprised me, not very nice. Will it be fixed in future versions?

@Andrew-Chen-Wang
Copy link
Member

Yes, this is a bad bug.

@Andrew-Chen-Wang Andrew-Chen-Wang self-assigned this Oct 10, 2022
@Andrew-Chen-Wang Andrew-Chen-Wang mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Andrew-Chen-Wang Andrew-Chen-Wang

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simevo @Andrew-Chen-Wang @MWGCLB