-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT support #397
Comments
It would be nice if django-oauth-toolkit implemented django-rest-framework-jwt similar to django-rest-auth. Edit: Or instead of django-rest-framework-jwt, maybe pyjwt would be better? Since django-oauth-toolkit is not dependent on the djangorestframework. Thanks! |
I'm currently looking at rfc7519 and that is the one we want, correct? Is this the core issue for JWT support in terms of django-oauth-toolkit? My choice would be pyjwt as that's already imported in oauthlib as an unused import. |
Any update on this feature? I see oauthlib has implemented JWT few weeks back. |
Please see the new oauthlib group for details on its jwt support. |
@duaneking can you leave an url for the group? Thanks. |
Hi everyone. I implemented an extension of this library to support JWT: https://github.com/Humanitec/django-oauth-toolkit-jwt The reason for not making a PR here was the lack of time and knowledge of where to put the pieces in the correct place. Also, I did it in the fastest way that it helps my company to make the job done as soon as possible. Anyway, if there are many interested people I could do the effort in my free time of porting it here but I would need some guidance first. |
@Menda Thanks for the heads up. Could you add a LICENSE file to your repo so we can maybe backport it into here more easily? |
@jleclanche I added a LICENSE file with MIT license, so anyone is free to use how they would like to. Thanks! |
Hello, we are very interested in this functionality as well! What is the upstream developers' position w.r.t. the fork? Are there any timelines? Is there anything we could do to help out? If yes, then I could try to budget it... |
Also, what is the support status of Django 1.11 LTS? Any chance this will get backported to Django 1.11 compatible version? Thank you! |
For it to be backported it'd first have to be mainlined. @zyv If you want to help, you can spend time taking the fork mentioned by @Menda and helping mainline it into upstream django-oauth-toolkit. This would be very much appreciated. If you do that, I recommend you detail your plan here first before you go ahead. |
It should help if anyone want to use it with django or do PRs accordingly. |
The installation dosent work |
Someone would need to fork it and maintain, since Humanitec is not using it anymore. |
How is the current implementation plan for JWT? I've seen that #252 but it seems this has not been followed up on. Are there currently plans to implement this or at leat allow custom token & refresh token configuration?
The text was updated successfully, but these errors were encountered: