Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JWT support #397

Closed
HitDaCa opened this issue Jul 1, 2016 · 15 comments
Closed

JWT support #397

HitDaCa opened this issue Jul 1, 2016 · 15 comments

Comments

@HitDaCa
Copy link

HitDaCa commented Jul 1, 2016

How is the current implementation plan for JWT? I've seen that #252 but it seems this has not been followed up on. Are there currently plans to implement this or at leat allow custom token & refresh token configuration?

@NathanUrwin
Copy link

NathanUrwin commented Nov 16, 2016

It would be nice if django-oauth-toolkit implemented django-rest-framework-jwt similar to django-rest-auth.

Edit: Or instead of django-rest-framework-jwt, maybe pyjwt would be better? Since django-oauth-toolkit is not dependent on the djangorestframework. Thanks!

@jleclanche jleclanche added this to the 1.0 milestone Feb 17, 2017
@jleclanche jleclanche modified the milestones: 1.0, 1.1 Jun 7, 2017
@duaneking
Copy link

duaneking commented Nov 13, 2017

I'm currently looking at rfc7519 and that is the one we want, correct?

Is this the core issue for JWT support in terms of django-oauth-toolkit?

My choice would be pyjwt as that's already imported in oauthlib as an unused import.

@prafulbagai
Copy link

Any update on this feature? I see oauthlib has implemented JWT few weeks back.

@duaneking
Copy link

Please see the new oauthlib group for details on its jwt support.

@filias
Copy link

filias commented May 7, 2018

@duaneking can you leave an url for the group? Thanks.

@duaneking
Copy link

@rafa-munoz
Copy link

rafa-munoz commented Jun 7, 2018

Hi everyone. I implemented an extension of this library to support JWT: https://github.com/Humanitec/django-oauth-toolkit-jwt

The reason for not making a PR here was the lack of time and knowledge of where to put the pieces in the correct place. Also, I did it in the fastest way that it helps my company to make the job done as soon as possible. Anyway, if there are many interested people I could do the effort in my free time of porting it here but I would need some guidance first.

@jleclanche
Copy link
Member

@Menda Thanks for the heads up. Could you add a LICENSE file to your repo so we can maybe backport it into here more easily?

@rafa-munoz
Copy link

@jleclanche I added a LICENSE file with MIT license, so anyone is free to use how they would like to. Thanks!

@zyv
Copy link

zyv commented Jun 11, 2018

Hello, we are very interested in this functionality as well! What is the upstream developers' position w.r.t. the fork? Are there any timelines? Is there anything we could do to help out? If yes, then I could try to budget it...

@zyv
Copy link

zyv commented Jun 11, 2018

Also, what is the support status of Django 1.11 LTS? Any chance this will get backported to Django 1.11 compatible version? Thank you!

@jleclanche
Copy link
Member

For it to be backported it'd first have to be mainlined.

@zyv If you want to help, you can spend time taking the fork mentioned by @Menda and helping mainline it into upstream django-oauth-toolkit. This would be very much appreciated. If you do that, I recommend you detail your plan here first before you go ahead.

@JonathanHuot
Copy link
Contributor

oauthlib documentation has been updated to help developers using JWT for access_token.

It should help if anyone want to use it with django or do PRs accordingly.
Please see https://oauthlib.readthedocs.io/en/latest/oauth2/tokens/bearer.html and don't hesitate to comment if anything gets wrong!

@kaemmi84
Copy link

kaemmi84 commented Mar 5, 2022

Hi everyone. I implemented an extension of this library to support JWT: https://github.com/Humanitec/django-oauth-toolkit-jwt

The reason for not making a PR here was the lack of time and knowledge of where to put the pieces in the correct place. Also, I did it in the fastest way that it helps my company to make the job done as soon as possible. Anyway, if there are many interested people I could do the effort in my free time of porting it here but I would need some guidance first.

The installation dosent work

@rafa-munoz
Copy link

Hi everyone. I implemented an extension of this library to support JWT: https://github.com/Humanitec/django-oauth-toolkit-jwt
The reason for not making a PR here was the lack of time and knowledge of where to put the pieces in the correct place. Also, I did it in the fastest way that it helps my company to make the job done as soon as possible. Anyway, if there are many interested people I could do the effort in my free time of porting it here but I would need some guidance first.

The installation dosent work

Someone would need to fork it and maintain, since Humanitec is not using it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests