Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work #4

Closed
CripyIce opened this issue Mar 4, 2020 · 9 comments
Closed

Doesn't work #4

CripyIce opened this issue Mar 4, 2020 · 9 comments

Comments

@CripyIce
Copy link

CripyIce commented Mar 4, 2020

This library don't seem to work at all. No errors though.
Flutter doctor:

[✓] Flutter (Channel beta, v1.14.6, on Mac OS X 10.15.3 19D76, locale en-IL)
 
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 11.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[!] VS Code (version 1.42.1)
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (3 available)
@java-james
Copy link
Owner

java-james commented Mar 11, 2020

Hey thanks for the issue report.
Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues.
Any specific error being thrown at runtime? Or you getting no overlay displayed when using it?
What does the code you've implemented it in look like?

@CripyIce
Copy link
Author

Hi @java-james , there are no errors.
This is my code - very simple:

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key}) : super(key: key);

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Overlay Test"),
      ),
      body: LoadingOverlay(
        isLoading: true,
        child: Column(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: <Widget>[
            Text(
              'Some text',
            ),
          ],
        ),
      ),
    );
  }
}

@aldwnesx
Copy link

not working as well

@aldwnesx
Copy link

Hey thanks for the issue report.
Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues.
Any specific error being thrown at runtime? Or you getting no overlay displayed when using it?
What does the code you've implemented it in look like?

1.12.13 doesn't exist?

@java-james
Copy link
Owner

Hey thanks for the issue report.
Any more details on this? I'm consuming on 1.12.13+hotfix.8 without issues.
Any specific error being thrown at runtime? Or you getting no overlay displayed when using it?
What does the code you've implemented it in look like?

1.12.13 doesn't exist?

Ah referring to the flutter version I'm running on. Thanks I will use the info you've provided to reproduce the issue and report back here.

@kashlo
Copy link

kashlo commented Mar 19, 2020

same, doesnt work when LoadingOverlay is child of Scaffold

@java-james
Copy link
Owner

Have had a look into this. Seems like there is an issue initializing isLoading as true. (It's not picked up in the init state of the loading overlay).
Can get working fine with your layout when initializing as false then changing to true via state.
Will push this fix and publish this week.

Screen Shot 2020-03-22 at 10 52 47 PM

@java-james
Copy link
Owner

Have pushed the update as 0.2.1
Please try this version and confirm the issue is fixed
James

@java-james
Copy link
Owner

Closing this issue. Fixed in 0.2.1 let me know if you have any other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants