Refactor request: replace Bluebird promises with native promises.

[filipesilva]

Description

This is a feature/refactor request.

html-webpack-plugin currently uses Bluebird promises, which use try...catch. Such blocks are a known de-optimization (GoogleChrome/devtools-docs#53 (comment)) in some versions of V8, like the one present in Node 6 (current LTS). Node 6 also has native promise support though.

Thus using Bluebird promises can cause decreased performance. Below are a few screenshots of a Webpack rebuild, showing the deopt is occurring (all within the innerArrayForEach group):

I tried replacing this specific use of Promise (it's the one in html-webpack-plugin/lib/compiler.js (compileTemplate) with a native promise and I observed roughly 200ms savings on a rebuild in that function group:

This doesn't mean that all builds would benefit from the same reduction, but since rebuild performance is of high value perhaps this is a worthwhile refactor.

It's worth mentioning that in the V8 engine 6.0 this isn't relevant anymore: https://www.nearform.com/blog/node-js-is-getting-a-new-v8-with-turbofan. But that might be a ways off for a lot of users.

Environment

Node.js v6.11.1
win32 10.0.15063
npm 5.3.0
webpack@3.5.5
html-webpack-plugin@2.30.1

[mastilver]

#762 (comment)

Node was required for node 0.10 but now for webpack 2 we can probably drop that dependency

If you want to submit a PR, go ahead :)

[filipesilva]

Here is a PR for it :#776. Travis seems happy with it.

[ngyikp]

v3.0.0 no longer uses bluebird, this issue can be closed
https://github.com/jantimon/html-webpack-plugin/pull/861/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L46

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.