You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have dropped a working enhancement into Actions. It allows parameters to be passed to a function. I found it very useful to act as conditional logic and to write an HTML generator that connected the generated HTML to the javascript supporting code.
I was not sure how if the pull request was performed the correct way. The code modification is about a dozen lines to Mustache.js plus the section added to README.md.
Cool to see you've come up with some really handy modifications that could be really useful for others as well, thanks for sharing 👍
I'll be honest and say I'm hesitant merging them primarily because of one reason; mustache.js is supposed to be a pure JavaScript implementation of the mustache spec. That's both good and bad, it works perfectly for many but lacks a lot of trivial features for others.
In practise that means syntax wise there isn't much room creativity for things not part of the mustache spec. I believe implementations in other languages, such the PHP equivalent, has introduced a concept in its core that allows anyone to extend the mustache syntax without touching the core library, called "pragma"s I believe. Sadly we haven't come to introducing that in mustache.js yet, but for me personally that's the sensible way to introduce unofficial syntax or features.
Would love ideas on how to communicate this properly in our README.md, which could have helped set your (and future contributors) expectations earlier.
I have dropped a working enhancement into Actions. It allows parameters to be passed to a function. I found it very useful to act as conditional logic and to write an HTML generator that connected the generated HTML to the javascript supporting code.
I was not sure how if the pull request was performed the correct way. The code modification is about a dozen lines to Mustache.js plus the section added to README.md.
It may also be an implementation of issue #677
The text was updated successfully, but these errors were encountered: