Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Default to always open left sidebar in settings (hide collapse sidebar icon) #4393

Open
1 of 3 tasks
LazyYuuki opened this issue Jan 3, 2025 · 3 comments
Open
1 of 3 tasks
Assignees
Labels
category: settings Settings, system monitoring components type: enhancement Improves a current feature

Comments

@LazyYuuki
Copy link

Jan version

0.5.12

Describe the Bug

On the UI, when you click on the right hand corner theme palette icon, the settings button at the bottom left corner is also highlighted. After which, you cannot click onto the settings button to go to the settings of model anymore.

Steps to Reproduce

  1. Be in any tab except for setting (eg. thread, hub, ...)
  2. Click on the theme palette on the top left corner.
  3. The settings button on the bottom left corner is also highlighted.
  4. Click on the settings button, nothing triggered.
  5. Click on another tab such as Thread.
  6. Click on the settings button again the model settings screen is shown as normal.

Screenshots / Logs

image

image

What is your OS?

  • MacOS
  • Windows
  • Linux
@LazyYuuki LazyYuuki added the type: bug Something isn't working label Jan 3, 2025
@github-project-automation github-project-automation bot moved this to Investigating in Jan & Cortex Jan 3, 2025
@imtuyethan
Copy link
Contributor

imtuyethan commented Jan 3, 2025

@LazyYuuki You cannot click on Settings icon because you're already in Settings.
I think it confuses you because the left sidebar is closed.

Screen.Recording.2025-01-03.at.12.36.54.PM.mov

@imtuyethan
Copy link
Contributor

I think we should default to always open left sidebar when users are in settings @urmauur

@imtuyethan imtuyethan changed the title bug: The theme and settings button is conflicting with each other enhancement: Default to always open left sidebar in settings (hide collapse sidebar icon) Jan 3, 2025
@imtuyethan imtuyethan added type: enhancement Improves a current feature and removed type: bug Something isn't working labels Jan 3, 2025
@imtuyethan imtuyethan moved this from Investigating to Scheduled in Jan & Cortex Jan 3, 2025
@imtuyethan imtuyethan added the category: settings Settings, system monitoring components label Jan 3, 2025
@LazyYuuki
Copy link
Author

Oh I didn't realise! I want to suggest, in that case, making the sidebar persistent when user click open or close instead of collapsing when user click away. This would make the navigation much more intuitive, because if I am in setting or Thread for example, if I open up the sidebar, I would want it to stay there until I am done with all my navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: settings Settings, system monitoring components type: enhancement Improves a current feature
Projects
Status: Scheduled
Development

No branches or pull requests

3 participants