Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not use precompiled binary? #5

Closed
septs opened this issue Sep 20, 2020 · 7 comments
Closed

Why not use precompiled binary? #5

septs opened this issue Sep 20, 2020 · 7 comments
Labels
performance

Comments

@septs
Copy link
Contributor

septs commented Sep 20, 2020

image

like https://github.com/golangci/golangci-lint-action

from https://github.com/linxGnu/gosmpp/runs/1140698513
@jandelgado jandelgado added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Sep 21, 2020
@jandelgado
Copy link
Owner

jandelgado commented Sep 21, 2020 •
edited
Loading

I'm not sure why you proposing the change. Is it to make sure that the correct version of gcov2lcov is used?

@septs
Copy link
Contributor Author

septs commented Sep 21, 2020

gh-actions run docker very slower.

@septs
Copy link
Contributor Author

septs commented Sep 21, 2020 •
edited
Loading

gh-actions per run job will build docker image.

the a process need ≈ 20s to 30s

direct use precompiled binary, in gh-actions expected in 5s.

@jandelgado jandelgado mentioned this issue Sep 23, 2020
Merged
@jandelgado
Copy link
Owner

implemented with release 1.0.4

@jandelgado
Copy link
Owner

can we close the issue, @septs ?

@septs
Copy link
Contributor Author

septs commented Oct 15, 2020

why docker based?

@jandelgado
Copy link
Owner

gcov2lcov needs installed go tooling available. Therefore a container. Feel free to Open a MR for further improvents - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@septs @jandelgado