From 1e02d79c020cded428dc1114d6b5034316341d2c Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sat, 8 Oct 2022 15:26:12 +0200 Subject: [PATCH 1/4] Update node version and use github-action for codecov Signed-off-by: Matthieu MOREL --- .github/workflows/unit-tests.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index acbf3120f9..0a0b98151a 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -15,17 +15,11 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: "10" - - name: install yarn - run: | - curl -o- -L https://yarnpkg.com/install.sh | bash - echo $HOME/.yarn/bin >>"$GITHUB_PATH" - echo $HOME/.config/yarn/global/node_modules/.bin >>"$GITHUB_PATH" + cache: yarn + node-version: '16' - run: yarn install --frozen-lockfile - run: yarn lint - run: yarn build - run: yarn coverage - name: Upload coverage to codecov.io - run: | - yarn global add codecov - codecov + uses: codecov/codecov-action@v3 From f32bd4712ed41c421a3ae968c3141bc6f4654169 Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sat, 8 Oct 2022 23:14:03 +0200 Subject: [PATCH 2/4] Update .github/workflows/unit-tests.yml Co-authored-by: Yuri Shkuro Signed-off-by: Matthieu MOREL --- .github/workflows/unit-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 0a0b98151a..8d87873806 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -23,3 +23,5 @@ jobs: - run: yarn coverage - name: Upload coverage to codecov.io uses: codecov/codecov-action@v3 + fail_ci_if_error: true + verbose: true From 0dd44329ad4a000cfc20520a0c14e7e51926f46d Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sat, 8 Oct 2022 23:16:24 +0200 Subject: [PATCH 3/4] Update to node 16 Signed-off-by: Matthieu MOREL --- .nvmrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.nvmrc b/.nvmrc index f599e28b8a..b6a7d89c68 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -10 +16 From bb0e53e909de4a4b8047e8e15b3c4503e9854fd4 Mon Sep 17 00:00:00 2001 From: Matthieu MOREL Date: Sun, 9 Oct 2022 10:21:44 +0200 Subject: [PATCH 4/4] Fix missing with keyword Signed-off-by: Matthieu MOREL --- .github/workflows/unit-tests.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index 8d87873806..570e4c201d 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -23,5 +23,6 @@ jobs: - run: yarn coverage - name: Upload coverage to codecov.io uses: codecov/codecov-action@v3 - fail_ci_if_error: true - verbose: true + with: + fail_ci_if_error: true + verbose: true