Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[embed] Enable configuration of any view when in embed mode #279

Closed
tiffon opened this issue Nov 24, 2018 · 0 comments · Fixed by #286
Closed

[embed] Enable configuration of any view when in embed mode #279

tiffon opened this issue Nov 24, 2018 · 0 comments · Fixed by #286

Comments

@tiffon
Copy link
Member

tiffon commented Nov 24, 2018

Requirement - what kind of business use case are you trying to solve?

Enhancement to embed mode, e.g. query param embed=....

Problem - what in Jaeger blocks you from solving the requirement?

Currently (in #263), when embedding a search view, it's not possible to customize the embedded view of trace-details. For instance, if the query param mapCollapsed is added to the embedded search page URL it will not be carried over to the trace detail view when a trace is selected from the search results.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Propagate embed query params when changing views.

Any open questions to address

Seems like this will be a breaking change so embed=vN+1 should be used to scope the effects of this change, where N is the current embed version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant