From 383386f4375f9c114007d2b553528c3c79c25ae0 Mon Sep 17 00:00:00 2001 From: Prithvi Raj Date: Thu, 27 Apr 2017 11:41:39 -0400 Subject: [PATCH 1/4] Add some ignores --- codecov.yml | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 codecov.yml diff --git a/codecov.yml b/codecov.yml new file mode 100644 index 000000000..cd2b3d5be --- /dev/null +++ b/codecov.yml @@ -0,0 +1,7 @@ +ignore: + - "jaeger-thrift" + - "jaeger-crossdock" + - "**/gen-java/**" + +coverage: + precision: 2 From 8788fab85aaca7b1d673d16167786af6d7f422f3 Mon Sep 17 00:00:00 2001 From: Prithvi Raj Date: Thu, 27 Apr 2017 15:08:33 -0400 Subject: [PATCH 2/4] Exclude jacoco data for thrift and crossdock - Exclude this in the gradle build so that code coverage may be checked locally as well --- build.gradle | 16 ++++++++++++++-- codecov.yml | 5 ----- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/build.gradle b/build.gradle index 5e4909a0d..983cb3610 100644 --- a/build.gradle +++ b/build.gradle @@ -30,7 +30,7 @@ allprojects { group = 'com.uber.jaeger' version = '0.19.0-SNAPSHOT' - + repositories { mavenCentral() } @@ -114,10 +114,22 @@ task codeCoverageReport(type: JacocoReport, group: 'Coverage reports') { } reports { - html.enabled = false + html.enabled = true xml.enabled = true xml.destination = "${buildDir}/reports/jacoco/report.xml" } + + afterEvaluate { + classDirectories = files(classDirectories.files.collect { + fileTree(dir: it, + exclude: ['**/crossdock/**', + '**/thrift/**', + '**/thriftjava/**', + ]) + }) + println "hobbit" + println classDirectories.asFileTree.files + } } configure(subprojects.findAll {it.name != 'jaeger-thrift'}) { diff --git a/codecov.yml b/codecov.yml index cd2b3d5be..35fd48b05 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,7 +1,2 @@ -ignore: - - "jaeger-thrift" - - "jaeger-crossdock" - - "**/gen-java/**" - coverage: precision: 2 From b2f5dd0e9ca19b5c2da07fa4ac034fef7d8b5033 Mon Sep 17 00:00:00 2001 From: Prithvi Raj Date: Thu, 27 Apr 2017 15:10:26 -0400 Subject: [PATCH 3/4] Remove printing --- build.gradle | 2 -- 1 file changed, 2 deletions(-) diff --git a/build.gradle b/build.gradle index 983cb3610..2cce555ba 100644 --- a/build.gradle +++ b/build.gradle @@ -127,8 +127,6 @@ task codeCoverageReport(type: JacocoReport, group: 'Coverage reports') { '**/thriftjava/**', ]) }) - println "hobbit" - println classDirectories.asFileTree.files } } From 5f0851a88741fb397e1fbf94ca8e7faf89eb6ff1 Mon Sep 17 00:00:00 2001 From: Prithvi Raj Date: Thu, 27 Apr 2017 15:35:39 -0400 Subject: [PATCH 4/4] Add space --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 35fd48b05..886ef33c9 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,2 +1,2 @@ coverage: - precision: 2 + precision: 2