You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Requirement - what kind of business use case are you trying to solve?
Currently, the internal contextFromString method resides in the JaegerSpanContext class. It produces a JaegerSpanContext instance from a string that conforms with the TextMapCodec. Arguably, this is not an ideal location for it to reside.
Problem - what in Jaeger blocks you from solving the requirement?
In the future, we would like to support other codecs, such as W3C trace identifiers (jaegertracing/jaeger#855). This method implies the only valid codec is the TextMapCodec seeing as it is the canonical method for using strings to produce JaegerSpanContext and implicitly relies on the TextMapCodec format.
Proposal - what do you suggest to solve the problem or improve the existing situation?
Move the contextFromString method into the TextMapCodec class instead.
The text was updated successfully, but these errors were encountered:
isaachier
changed the title
Move internal method contextFromString out of JaegerSpanContext
Move internal method contextFromString out of JaegerSpanContext
Aug 17, 2018
Requirement - what kind of business use case are you trying to solve?
Currently, the internal
contextFromString
method resides in theJaegerSpanContext
class. It produces aJaegerSpanContext
instance from a string that conforms with theTextMapCodec
. Arguably, this is not an ideal location for it to reside.Problem - what in Jaeger blocks you from solving the requirement?
In the future, we would like to support other codecs, such as W3C trace identifiers (jaegertracing/jaeger#855). This method implies the only valid codec is the
TextMapCodec
seeing as it is the canonical method for using strings to produceJaegerSpanContext
and implicitly relies on theTextMapCodec
format.Proposal - what do you suggest to solve the problem or improve the existing situation?
Move the
contextFromString
method into theTextMapCodec
class instead.The text was updated successfully, but these errors were encountered: