Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "warnings" from prometheus upstream #169

Closed
4 tasks done
jacksontj opened this issue Jun 15, 2019 · 0 comments · Fixed by #174
Closed
4 tasks done

Add "warnings" from prometheus upstream #169

jacksontj opened this issue Jun 15, 2019 · 0 comments · Fixed by #174

Comments

@jacksontj
Copy link
Owner

jacksontj commented Jun 15, 2019

Split from #141 (replacement of #168)
TLDR; upstream prometheus added a "storage.Warnings" which it uses for non-primary datasource reads. This pr is for adding support for such a thing

TODO:

  • support "merging" warnings
  • add "make_warnings" option, similar to "ignore_error" except instead of ignoring we make them warnings
  • add "make_errors" option, similar to "make_warnings" except we take warnings and make them errors
  • add warnings to NodeReplacer

References/links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant