Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logstash message format #30

Closed
dragn opened this issue Apr 27, 2015 · 1 comment
Closed

Logstash message format #30

dragn opened this issue Apr 27, 2015 · 1 comment

Comments

@dragn
Copy link

dragn commented Apr 27, 2015

Hi.

The format of Logstash message has been changed some time ago (https://gist.github.com/jordansissel/2996677, note the message instead of @message). Sadly, these changes was not reflected in winstonjs.
Winston also has proposed change to remove logstash option in favor of custom formatter (winstonjs/winston#452). And, I think, It is a right thing to do, having logstash-related code in winston seems pretty hack-ish to me.
So I reckon that we should use custom formatter here instead of logstash : true.
@dragn
Copy link
Author

dragn commented Apr 27, 2015

Wait, I just discovered that the issue I have is not related to winston-logstash. I don't use logstash : true, and it is not set to true by default (as I thought). The message format inconsistencies is somehow related to Logstash itself.

@dragn dragn closed this as completed Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dragn