From d9e93c812bbd44ab3911a5d9d74e8cf642cb0d24 Mon Sep 17 00:00:00 2001 From: Matthew Wire Date: Wed, 15 Jun 2022 12:21:39 +0100 Subject: [PATCH] Revert freezing on total_amount field on recurring form --- CRM/Contribute/Form/UpdateSubscription.php | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/CRM/Contribute/Form/UpdateSubscription.php b/CRM/Contribute/Form/UpdateSubscription.php index a5772c74ce5b..ea02ea7d633a 100644 --- a/CRM/Contribute/Form/UpdateSubscription.php +++ b/CRM/Contribute/Form/UpdateSubscription.php @@ -155,13 +155,17 @@ public function buildQuickForm() { TRUE, 'currency', $this->_subscriptionDetails->currency, TRUE ); + // https://lab.civicrm.org/dev/financial/-/issues/197 https://github.com/civicrm/civicrm-core/pull/23796 + // Revert freezing on total_amount field on recurring form - particularly affects IATs + // This will need revisiting in the future as updating amount on recur does not work for multiple lineitems. + // Also there are "point of truth" issues ie. is the amount on template contribution or recur the current one? // The amount on the recurring contribution should not be updated directly. If we update the amount using a template contribution the recurring contribution // will be updated automatically. - $paymentProcessorObj = Civi\Payment\System::singleton()->getById(CRM_Contribute_BAO_ContributionRecur::getPaymentProcessorID($this->contributionRecurID)); - $templateContribution = CRM_Contribute_BAO_ContributionRecur::getTemplateContribution($this->contributionRecurID); - if (!empty($templateContribution['id']) && $paymentProcessorObj->supportsEditRecurringContribution()) { - $amountField->freeze(); - } + // $paymentProcessorObj = Civi\Payment\System::singleton()->getById(CRM_Contribute_BAO_ContributionRecur::getPaymentProcessorID($this->contributionRecurID)); + // $templateContribution = CRM_Contribute_BAO_ContributionRecur::getTemplateContribution($this->contributionRecurID); + // if (!empty($templateContribution['id']) && $paymentProcessorObj->supportsEditRecurringContribution()) { + // $amountField->freeze(); + // } $this->add('text', 'installments', ts('Number of Installments'), ['size' => 20], FALSE);