Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Download of subtitle files fails. #2977

Closed
linux-lukas opened this issue Mar 18, 2022 · 9 comments · Fixed by #3087
Closed

[Bug] Download of subtitle files fails. #2977

linux-lukas opened this issue Mar 18, 2022 · 9 comments · Fixed by #3087
Labels
bug Something isn't working type:server-side

Comments

@linux-lukas
Copy link

Describe the bug
When downloading subtitle files, I noticed that this process always fails.

Steps to Reproduce

  1. Go to a video you like.
  2. Try to download a subtitle file.
  3. See error

Logs
Title: Missing hash key: "id" (KeyError)
Date: 2022-03-18T07:40:23Z
Route: /download
Version: 2022.03.15-5b82370b @ master

Backtrace 

Missing hash key: "id" (KeyError)
  from /usr/share/crystal/src/hash.cr:1034:28 in 'captions'
  from lib/kemal/src/kemal/route.cr:13:9 in '->'
  from /usr/share/crystal/src/primitives.cr:266:3 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/filter_handler.cr:21:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/invidious/helpers/static_file_handler.cr:112:11 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/init_handler.cr:12:7 in 'process'
  from /usr/share/crystal/src/http/server.cr:500:5 in '->'
  from /usr/share/crystal/src/primitives.cr:266:3 in 'run'
  from ???

Screenshots
bug-invidious

Additional context

  • Mozilla Firefox 98.0
  • Linux (Ubuntu 20.04.3 LTS)
@linux-lukas linux-lukas added the bug Something isn't working label Mar 18, 2022
@unixfox
Copy link
Member

unixfox commented Mar 18, 2022

Which instance are you using?

@linux-lukas
Copy link
Author

Which instance are you using?

I have tried it on the following Invidious instances:

@SamantazFox
Copy link
Member

Ah, yep, I can reproduce! It is caused by #2922. I'll try to fix that today.

@linux-lukas

This comment was marked as off-topic.

Sign in to view
@unixfox

This comment was marked as off-topic.

Sign in to view
@julianfairfax

This comment was marked as off-topic.

Sign in to view
@unixfox

This comment was marked as off-topic.

Sign in to view
@TheFrenchGhosty
Copy link
Member

@SamantazFox

Ah, yep, I can reproduce! It is caused by #2922. I'll try to fix that today.

You forgot I think

@DrDustwolf
Copy link

I can reproduce the issue on:
https://invidious.snopyta.org/
https://invidious-us.kavin.rocks/

@SamantazFox SamantazFox mentioned this issue May 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working type:server-side
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix download of captions iv-org/invidious
6 participants
@unixfox @DrDustwolf @julianfairfax @TheFrenchGhosty @linux-lukas @SamantazFox