Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data story] Empty window selecting "edit icon" from a story created from another user #235

Open
mariaclaudia opened this issue May 9, 2018 · 1 comment

Comments

@mariaclaudia
Copy link
Collaborator

mariaclaudia commented May 9, 2018

Subject of the issue

Selecting "Edit icon" from a story created from a different user, an empty window is displayed

Your environment

Chrome - Version 66.0.3359.139 (Official Build) (64-bit)

Steps to reproduce

screen shot 2018-05-09 at 16 14 33

Actual behaviour

I don't know if it's correct that the "Edit" button is displayed.
If it's correct, when I click on edit, an empty window is provided

screen shot 2018-05-09 at 16 14 41

Expected behaviour

If it's correct to have the edit icon, you can use the existing story as your initial point and then save it as a new one and it should not be displayed an empty window.

@mariaclaudia mariaclaudia changed the title [Storia] Empty window selecting "edit icon" from a story created from another user [Data stories] Empty window selecting "edit icon" from a story created from another user Jun 15, 2018
@mariaclaudia mariaclaudia changed the title [Data stories] Empty window selecting "edit icon" from a story created from another user [Data story] Empty window selecting "edit icon" from a story created from another user Jun 15, 2018
@mariaclaudia
Copy link
Collaborator Author

Now the content is correctly displayed, but a user can modify an existing data stories from another user (edit icon enabled).
Should this function create a copy of the original one maintaining both?
Should this function update the author from the original data story?

Which is the expected behaviour?

Thanks @raippl @giux78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant