Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper client "not implemented" on tonic error #525

Closed
howardjohn opened this issue May 19, 2023 · 3 comments
Closed

hyper client "not implemented" on tonic error #525

howardjohn opened this issue May 19, 2023 · 3 comments

Comments

@howardjohn
Copy link
Member

thread 'main' panicked at 'not yet implemented', /usr/local/google/home/howardjohn/.cargo/git/checkouts/hyper-util-7fd38a0cfc1cd33b/b9eaeca/src/client/legacy.rs:743:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I thought it could only happen in tests but looks like in real world its happening as well. need to imlpement it in hyper client or stop using it

@film42
Copy link
Contributor

film42 commented May 21, 2023

I opened a PR to hyper-util with error conversions (removing todo()s), but I'm not sure if it's way off or not. If it looks right, feel free to merge it into your branch since Cargo.toml is pointed at your fork atm.

@ilrudie
Copy link
Contributor

ilrudie commented Jul 13, 2023

Quick status update based on what I found when looking if this issue could be closed:

Presently, pending 2 PRs, ztunnel consumes John's fork of hyper-util. Pulling the fix from @film42 into ztunnel could occur with a rebase of the branch we consume in John's fork or, after the pending PRs merge, by consuming the upstream again.

@howardjohn
Copy link
Member Author

No more todo!() left , closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants