Convert existing PR into drafts

[alerque]

The new Draft PR feature (#416) is a great concept, but it is very difficult make use of without being able to change the status of existing PRs. It was mentioned in that issue that conversion was needed, but since the issue is closed (with the main feature implemented) I guess it's time for an issue specifically to track this addition.

PR owners and project maintainers should be able to change the status on existing PRs to mark them as drafts.

According to both the previous PR and this Twitter thread, this request has come to the attention of at least one product manager and Github.

[clarkbw]

Working on it

[alerque]

@TPS This and #1551 are really not even related to all the other issues that have the saved / draft tag, I would suggests that is a miss categorization. Drafts of comments and other messages are a completely different animal (and only visible to end users) from the draft status on PRs.

[TPS]

OT: We collaborators are having a dialogue re: best use of labels, but my rule-of-thumb is try to use label combinations that best express what the issue's about, so saved / draftpull-requests makes sense, IMHO.

[xeruf]

any progress on this? I have quite a few WIP PRs in my repos and it would be great if I could just switch them to be Drafts!

[wcox13]

I am also curious whether this is still in progress. It would definitely be useful.

[TomasVotruba]

I accidently created PR and wanted to go draft. Now I get lot of unwanted feedback :/
This feature could save my time and time of willing feedbackers.

[priyankapatel1289]

@TomasVotruba You know you can still remove the reviewers? Then maybe change the title and add "Draft" to it

[TomasVotruba]

@priyankapatel1289 I can, but that won't stop feedback from people, that I don't want now

[radrow]

Labels and adding "[draft]" to PR title won't block merging, which is imo the coolest feature of drafts. I don't think this issue is very hard to solve...

[mrgilman]

Hi! We just shipped this feature today. Here's the changelog entry: https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft

[karenetheridge]

@mrgilman You are a prince among men! thank you very much.

[mrgilman]

@karenetheridge I prefer princess, but I'll take it 😁

[karenetheridge]

oops sorry, I didn't mouseover to get an expansion of your name. so sorry! :> :> :>

[cjw296]

@mrgilman - any idea when this is coming to GHE?

[TPS]

@cjw296, @mrgilman: Umm, I'm not a 🤖.…

[samirmhsnv]

Hi! We just shipped this feature today. Here's the changelog entry: https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft

Wow! Nice to hear it!

[mrgilman]

@cjw296 it'll either be in the upcoming release or the following one, not sure yet.

[antodoms]

Yay... this is released finally!!

[benwinding]

Was delighted to see this feature subtly introduced!

[vvval]

This option is not presented in one of my PRs. I had to close the PR and reopen it (and choose "draft" in the dropdown section)

[mcolyer]

This option is not presented in one of my PRs. I had to close the PR and reopen it (and choose "draft" in the dropdown section)

Can you provide any more detail around this? Has it happened more than once?

[timotheecour]

this feature only seems to work when there are some reviewers requesting changes (not just comments but comments marked as review comments, eg requesting changes through github UI), eg:

• appears here: avoid messing up changelog history on each subsequent release nim-lang/Nim#14025
• doesn't appear here: $ works for ref|ptr|pointer for all targets (c,cpp,js,vm) + other bugfixes nim-lang/Nim#14043

and since we can't request changes for our own PR's, the hack I tried (request change on my own PR) can't work either...

[mcolyer]

@timotheecour thanks, we'll take a closer look and see if we can figure out what's going on.

[mr-feek]

Just wanted to share that I'm loving this feature!

[EmilyRosina]

Does anyone know of a github action where we can change labels when the draft status is changed?

Ideally we'd be able to:

• When converted to draft add "wip" label, remove "ready" label
• When converted to ready to review remove "wip" label, add "ready" label

[jinmayamashita]

When converted to ready to review remove "wip" label, add "ready" label

@EmilyRosina my action is still a work in progress, but I hope it helps you.
https://github.com/marketplace/actions/ready-for-review.

[EmilyRosina]

@jinmayamashita oh wow that's awesome, thank you 🎉