Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic routes until we figure out how to do proper queries #142

Closed
treeder opened this issue Oct 12, 2016 · 1 comment
Closed

Remove dynamic routes until we figure out how to do proper queries #142

treeder opened this issue Oct 12, 2016 · 1 comment
Assignees
Milestone

Comments

@treeder
Copy link
Contributor

treeder commented Oct 12, 2016

We can't have this: https://github.com/iron-io/functions/blob/master/api/server/runner.go#L92
An app could have thousands of routes, we only want to query what's required.

See #77 for discussion on how to solve this problem.

@treeder treeder added this to the Beta milestone Oct 12, 2016
@treeder
Copy link
Contributor Author

treeder commented Oct 12, 2016

Current docs in README for reference:

Adding a route with URL params

You can create a route with dynamic URL parameters that will be available inside your function by prefixing path segments with a :, for example:

$ curl -H "Content-Type: application/json" -X POST -d '{
     "route": {
         "path":"/comments/:author_id/:num_page",
         "image":"IMAGE_NAME"
     }
}' http://localhost:8080/v1/apps/myapp/routes

:author_id and :num_page in the path will be passed into your function as PARAM_AUTHOR_ID and PARAM_NUM_PAGE.

See the Blog Example.

@ucirello ucirello self-assigned this Oct 14, 2016
@seiflotfy seiflotfy removed their assignment Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants