From 17cdf390accc9a127bb5d7894d0bbf1cf22c4eef Mon Sep 17 00:00:00 2001 From: Googler Date: Thu, 30 May 2019 12:52:33 -0700 Subject: [PATCH] Flip --incompatible_objc_framework_cleanup flag to true RELNOTES[INC]: cleanup that affects user provided apple frameworks is now enabled by default. See https://github.com/bazelbuild/bazel/issues/7944 for more info. PiperOrigin-RevId: 250743310 --- .../devtools/build/lib/packages/StarlarkSemanticsOptions.java | 2 +- .../com/google/devtools/build/lib/syntax/StarlarkSemantics.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 143904c9b8c906..56b64015b25316 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java @@ -572,7 +572,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl @Option( name = "incompatible_objc_framework_cleanup", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = { diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index eb6b5490dd56e6..52c703af04ff09 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java @@ -251,7 +251,7 @@ public static Builder builderWithDefaults() { .incompatibleNoSupportToolsInActionInputs(false) .incompatibleNoTargetOutputGroup(false) .incompatibleNoTransitiveLoads(true) - .incompatibleObjcFrameworkCleanup(false) + .incompatibleObjcFrameworkCleanup(true) .incompatibleRemapMainRepo(false) .incompatibleRemoveNativeMavenJar(false) .incompatibleRestrictNamedParams(false)