Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CPU ABI naming in the benchmark #8631

Closed
pzread opened this issue Mar 24, 2022 · 1 comment · Fixed by #18144
Closed

Improve CPU ABI naming in the benchmark #8631

pzread opened this issue Mar 24, 2022 · 1 comment · Fixed by #18144
Labels
infrastructure/benchmark Relating to benchmarking infrastructure infrastructure Relating to build systems, CI, or testing

Comments

@pzread
Copy link
Contributor

pzread commented Mar 24, 2022

Currently we have __get_arm_cpu_arch_revision in the benchmark tool to derive the subversion of ARM processor, such as ARMv8.2-A. Our method to derive it is not complete, and we might just want to have ARMv8-A. However, there are also ARMv9 processors reporting ARMv8-A as CPU ABI, and we still want to differentiate them.

Changing the naming will also invalid the existing records in perf dashboard, we need a backfill to fix them.

@pzread pzread added the infrastructure/benchmark Relating to benchmarking infrastructure label Mar 24, 2022
@antiagainst
Copy link
Contributor

antiagainst commented Mar 24, 2022

Thanks for capturing this! Yeah it'll need to rewrite existing benchmark names, which we have done once previously. I can do it again.

For armv9 devices (like moto edge x30 we have right now), we might need to look at more information from adb shell getprop to differentiate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure/benchmark Relating to benchmarking infrastructure infrastructure Relating to build systems, CI, or testing
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

4 participants