Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TKW] Feature Request: waves_per_block dimensionality should match workgroups #392

Open
GMNGeoffrey opened this issue Jan 16, 2025 · 0 comments

Comments

@GMNGeoffrey
Copy link
Contributor

The waves_per_block argument to tkw.HardwareConstraint currently has to be of length 3. Wave supports logical workgroup distribution along more than 3 dimensions and then figures out the mapping later. It should do the same with waves_per_block. Related to this, there are several sharp edges with the current setup:

  1. If you have a workgroup dimension with block size other than 1 at index 3 or greater, the Wave compiler tries to look up waves_per_block at that index and fails with an IndexError
  2. If you try to make waves_per_block longer than 3, the program crashes (looks like a segfault on the C side or something).
  3. You have to specify waves_per_block for dimensions that you're not distributing along.

FYI @harsh-nod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant