You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apologies if this has been discussed before. I noticed that the conda recipe for this project does quite a bit in the post-link phase. Namely it runs jupyter-contrib-nbextension install, which has the effect of copying a lot of files around and editing some other files in place.
I just wanted to discuss the feasibility of moving all this into the build phase of the conda recipe, and publishing the result as a conda package without any post-link script. For the files that are edited in place, this seems relevant: jupyter/notebook#3116. It should be possible to avoid needing to edit any existing files, and just create new files in *.d/ directories instead.
Has anyone tried this already? Is there some major reason that I'm missing why this wouldn't work?
The text was updated successfully, but these errors were encountered:
Hi! No, no reason not to do it that I know of. I just I haven't had time to do anything to this repo for a while, so haven't looked into the new .d stuff. If you fancy dropping a pr, feel free :)
If the last one is violated (Depend only on simple system tools such as rm, cp, mv and ln.) then there would definitely be pre-link and post-link.sh errors during environmet creation/removing.
Apologies if this has been discussed before. I noticed that the conda recipe for this project does quite a bit in the post-link phase. Namely it runs
jupyter-contrib-nbextension install
, which has the effect of copying a lot of files around and editing some other files in place.I just wanted to discuss the feasibility of moving all this into the build phase of the conda recipe, and publishing the result as a conda package without any post-link script. For the files that are edited in place, this seems relevant: jupyter/notebook#3116. It should be possible to avoid needing to edit any existing files, and just create new files in
*.d/
directories instead.Has anyone tried this already? Is there some major reason that I'm missing why this wouldn't work?
The text was updated successfully, but these errors were encountered: