Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag/put HTTP API enhancement #4722

Closed
vmx opened this issue Feb 20, 2018 · 3 comments
Closed

dag/put HTTP API enhancement #4722

vmx opened this issue Feb 20, 2018 · 3 comments

Comments

@vmx
Copy link
Member

vmx commented Feb 20, 2018

Version information:

go-ipfs version: 0.4.14-dev-25eeb1e25
Repo version: 6
System version: amd64/linux
Golang version: go1.9.2

Type: Enhancement

Description:

In the HTTP API currently a dag/put returns the CID (as link). Similar endpoints return other things:

  • block/put: Key (which is the CID) and Size
  • add: Name, Hash (which is the CID), Bytes, Size

Should dag/put also return the size and return the CID not as link, but just the hash?

@Kubuxu
Copy link
Member

Kubuxu commented Mar 16, 2018

I think it was done on purpose, we want to have links instead of CIDs but we can't change old APIs.

@magik6k
Copy link
Member

magik6k commented May 14, 2019

Ideally all endpoints would embed CIDs as IPLD links to make things more consistent, but that reqiires http-api v2 or something like that

Closing as there isn't much we can do about this

@magik6k magik6k closed this as completed May 14, 2019
@vmx
Copy link
Member Author

vmx commented May 15, 2019

Just a note (for people stumbling over this issue). IPLD links are not a thing anymore, the IPLD implementations now use the program language specific representation of CIDs. I'd called it "JSON representation of Links".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants