Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hasher blake2b-256 #435

Closed
SgtPooki opened this issue Sep 5, 2024 · 1 comment · Fixed by #436
Closed

feat: add hasher blake2b-256 #435

SgtPooki opened this issue Sep 5, 2024 · 1 comment · Fixed by #436
Assignees
@SgtPooki
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/in-progress In progress

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Sep 5, 2024

A user in #ipfs-community-help on slack was trying to use explorer page in ipfs-desktop and was shown the error:

image

@aschmahmann says we should have blake2b-256 in the explore page.

This issue will be considered done when the explore page handle CIDs hashed with the blake2b-256 hasher
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Sep 5, 2024
@SgtPooki SgtPooki self-assigned this Sep 5, 2024
@SgtPooki SgtPooki added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up P0 Critical: Tackled by core team ASAP effort/hours Estimated to take one or several hours status/in-progress In progress and removed need/triage Needs initial labeling and prioritization labels Sep 5, 2024
@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 5, 2024

FYI: I added some instructions for how to do this a while ago at https://github.com/ipfs/ipld-explorer-components#adding-another-hasher

@SgtPooki SgtPooki linked a pull request Sep 5, 2024 that will close this issue
feat: add blake2b-256 hasher #436
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature P0 Critical: Tackled by core team ASAP status/in-progress In progress
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add blake2b-256 hasher ipfs/ipld-explorer-components
1 participant
@SgtPooki