PDF Viewer Refreshes when interacting with webui

[whizzzkid]

Describe the bug
While interacting with other elements on page, the PDF viewer re-renders.

To Reproduce
Steps to reproduce the behavior:

1. Import a sample PDF in either webui/desktop
2. Try interacting with ui elements around the pdf
3. PDF viewer re-renders.
4. ReRenders can be expensive and based on the size of file it can take longer.

Expected behavior
It should not re-render.

Screenshots

pdf-view-re-renders.mov

Desktop (please complete the following information):

• OS: MacOS Ventura 13.5 (22G74)
• Browser Chrome, IPFS - Desktop
• Version Version 115.0.5790.114 (Official Build) (arm64), webui: a43dd23

Additional context
It looks like it should be fairly straightforward to remove pdf-view updates from the rendering cycle.

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[MattWong-ca]

Hey @SgtPooki @lidel

I'm Matt, currently going through Protocol Labs Dev Guild cohort 1. I was able to replicate this on local.

In FilesPage.js, MainView is defined as a new component inside the FilesPage component, so clicking UI elements around the PDF re-renders MainView (and since MainView contains the logic that shows the file preview component, the preview re-renders). Issue seemed to only affect PDFs.

I was able to find a fix by creating and using a new file preview component defined outside of FilePages. Will submit a PR!

[ipfs-gui-bot]

🎉 This issue has been resolved in version 4.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀