ipfs.files.add: cb is not a function

[chpio]

TypeError: cb is not a function - TypeError: cb is not a function
at Object.add (/usr/src/app/node_modules/ipfs-api/lib/api/add.js:16:14)

using _Promise_s

[nginnever]

Hello chpio! Thanks for pointing this out. Could you describe a test case when this error is thrown? Or what you are trying to add. I believe that promise should reject an error there when you provide add with invalid input.

We have a test case here in interface-ipfs-core that tests files.add promise adding a buffer.

https://github.com/ipfs/interface-ipfs-core/blob/master/src/files.js#L138

[chpio]

https://github.com/ipfs/js-ipfs-api/blob/master/src/api/add.js#L18

this code can only work with a cb if Promises are used there is no cb passed in.

[daviddias]

Fixed on #309. reopen as necessary

[chpio]

cb is not a function, not add

[daviddias]

@chpio you are right, fixing on: #314

[chpio]

offtopic: wouldn't it be better to have one basic implementation (only using callbacks) and a small wrapper for promises (requirable through var ipfsApi = require('ipfs-api/promise')(Promise);)

[daviddias]

Could you elaborate on what 'better' would mean? Our current API comes from a consensus after many discussions and several people involved, but of course, we are always open to things to make things better :)

[chpio]

ok... my perspective is better = simper (in this case)

edit: simplicity is not a thing in js-ipfs-api anyway ;)

[daviddias]

It doesn't have to be complex :), in fact, we are working towards making the code simpler and the API well documented, see:

• next generation #305
• https://github.com/ipfs/interface-ipfs-core

[chpio]

adding is not working any more in the new version (6.0.3). 6.0.2 is working.

[chpio]

i thought it's a broken Promise implementation in node v4 but it's not ;(
verified by using bluebird: global.Promise = Promise;

[kenshyx]

Can confirm this, I can't return a promise from api.add

TypeError: callback is not a function
      at Function.<anonymous> (node_modules/ipfs-api/lib/api/add.js:12:7)
      at Promise (node_modules/promisify-es6/index.js:36:20)
      at Object.add (node_modules/promisify-es6/index.js:30:16)

[chpio]

uhh i see now...

return promisify((files, callback) => [...]
the options argument (the 2. one) disappeared. Im calling it with {recursive: true}, is this still needed?

[kenshyx]

Yep, the problem is that the callback receives the options if specified. I saw here 628c197 some upcoming breaking changes.