Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure dockerfiles work well in any architectures #1085

Closed
hsanjuan opened this issue Apr 21, 2020 · 5 comments · Fixed by #1984
Closed

Make sure dockerfiles work well in any architectures #1085

hsanjuan opened this issue Apr 21, 2020 · 5 comments · Fixed by #1984
Assignees
@hsanjuan
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Milestone
Release v1.0.7

Comments

@hsanjuan
Copy link
Collaborator

Describe the feature you are proposing

Our docker containers should be able to run in different architectures and be built for them.

Additional context

Go-ipfs is probablly a good example on how to do this. This needs porting of things like https://github.com/krallin/tini/releases/download .
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels Apr 21, 2020
@omkarprabhu-98
Copy link
Contributor

Link: https://github.com/krallin/tini/releases/

Docker has an experimental CLI plugin for multi-arch builds

@hsanjuan
Copy link
Collaborator Author

Usually we can copy most of the things from how go-ipfs does it.

@omkarprabhu-98
Copy link
Contributor

Ah okay!
I'll make an attempt, any suggestions on how to test it to make sure it works?

@omkarprabhu-98 omkarprabhu-98 mentioned this issue Jul 22, 2020
Merged
@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Oct 9, 2023

Here's an easy dockerfile which I think supports multiarch and includes some other nice things we haven't used yet: https://github.com/ipfs/rainbow/blob/main/Dockerfile

This was referenced Oct 11, 2023
Closed
Closed
@hsanjuan
Copy link
Collaborator Author

https://github.com/ipfs/kubo/blob/master/.github/workflows/docker-image.yml too as reference.

@hsanjuan hsanjuan linked a pull request Oct 12, 2023 that will close this issue
Docker: support multiarch builds #1984
Merged
@hsanjuan hsanjuan added this to the Release v1.0.7 milestone Oct 12, 2023
@hsanjuan hsanjuan self-assigned this Oct 12, 2023
@hsanjuan hsanjuan removed the help wanted Seeking public contribution on this issue label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsanjuan hsanjuan

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
Release v1.0.7
Development

Successfully merging a pull request may close this issue.

Docker: support multiarch builds ipfs-cluster/ipfs-cluster
2 participants
@hsanjuan @omkarprabhu-98