From b0133131d281e5532a83bd639bca0d0f0cd1c4ba Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 15:41:28 +0100 Subject: [PATCH 01/13] Fix: fix golantci lint --- .github/workflows/reviewdog.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 22d205443b..47905f8208 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -12,6 +12,10 @@ jobs: - name: Checkout repository uses: actions/checkout@v2 + - uses: actions/setup-go@v2 + with: + go-version: "^1.16.2" + - name: Run golangci-lint # reviewdog v1.19.0, golangci-lint v1.38.0 uses: reviewdog/action-golangci-lint@93be4324306dcbba508544d891a7b0576bb28ddd with: From 2d9b4e87365029d6110fa633e192e0c4aa2481ce Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:03:10 +0100 Subject: [PATCH 02/13] Refactor: removed git from rev which fails in an action --- .github/workflows/reviewdog.yml | 1 + .golangci.yml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 47905f8208..daf3209f3b 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -22,3 +22,4 @@ jobs: github_token: ${{ secrets.github_token }} golangci_lint_flags: "--timeout=10m" reporter: "github-pr-review" + only-new-issues: true diff --git a/.golangci.yml b/.golangci.yml index af0e3d95ad..302e138ac2 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,7 +2,6 @@ issues: exclude-use-default: false max-issues-per-linter: 0 max-same-issues: 0 - new-from-rev: e79d2a0c90ae4c80aa56afebcd06d5540bbdc75f # Enhance golangci-lint (#1113) exclude: - 'Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked' # errcheck - 'err113: do not define dynamic errors, use wrapped static errors instead:' # goerr113 From 5c4d50d77a6a10dafaa8db643de170822a03e5a2 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:07:51 +0100 Subject: [PATCH 03/13] Refactor: blub --- .github/workflows/reviewdog.yml | 1 - .golangci.yml | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index daf3209f3b..47905f8208 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -22,4 +22,3 @@ jobs: github_token: ${{ secrets.github_token }} golangci_lint_flags: "--timeout=10m" reporter: "github-pr-review" - only-new-issues: true diff --git a/.golangci.yml b/.golangci.yml index 302e138ac2..b9b056c7ff 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,6 +2,7 @@ issues: exclude-use-default: false max-issues-per-linter: 0 max-same-issues: 0 + only-new-issues: true exclude: - 'Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked' # errcheck - 'err113: do not define dynamic errors, use wrapped static errors instead:' # goerr113 From cb09a45a42860e5cba0b448328317fc97fde4bda Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:11:29 +0100 Subject: [PATCH 04/13] Refactor: add error --- .golangci.yml | 2 +- packages/markers/sequence.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index b9b056c7ff..af0e3d95ad 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,7 +2,7 @@ issues: exclude-use-default: false max-issues-per-linter: 0 max-same-issues: 0 - only-new-issues: true + new-from-rev: e79d2a0c90ae4c80aa56afebcd06d5540bbdc75f # Enhance golangci-lint (#1113) exclude: - 'Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked' # errcheck - 'err113: do not define dynamic errors, use wrapped static errors instead:' # goerr113 diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 8d4efea8a1..13775144a0 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -364,7 +364,7 @@ func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { return marshalUtil.Bytes() } -// String returns a human readable version of the SequenceIDs. +// Stringse returns a human readable version of the SequenceIDs. func (s SequenceIDs) String() (humanReadableSequenceIDs string) { result := "SequenceIDs(" firstItem := true From 8bb2aa65c9ce395171c3fdfd02ea7bb30fa75f2c Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:15:36 +0100 Subject: [PATCH 05/13] Refactor: reverted intentional error --- packages/markers/sequence.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 13775144a0..8d4efea8a1 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -364,7 +364,7 @@ func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { return marshalUtil.Bytes() } -// Stringse returns a human readable version of the SequenceIDs. +// String returns a human readable version of the SequenceIDs. func (s SequenceIDs) String() (humanReadableSequenceIDs string) { result := "SequenceIDs(" firstItem := true From a519228586b63e11a92f5592b2233eb8f35f248d Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:16:28 +0100 Subject: [PATCH 06/13] Refactor: refactor golangci.yml --- .golangci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index af0e3d95ad..b9b056c7ff 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,7 +2,7 @@ issues: exclude-use-default: false max-issues-per-linter: 0 max-same-issues: 0 - new-from-rev: e79d2a0c90ae4c80aa56afebcd06d5540bbdc75f # Enhance golangci-lint (#1113) + only-new-issues: true exclude: - 'Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked' # errcheck - 'err113: do not define dynamic errors, use wrapped static errors instead:' # goerr113 From 41bf91072561d7318d40fcc27c8f7f660859d160 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:20:48 +0100 Subject: [PATCH 07/13] Refactor: added error again --- packages/markers/sequence.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 8d4efea8a1..13775144a0 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -364,7 +364,7 @@ func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { return marshalUtil.Bytes() } -// String returns a human readable version of the SequenceIDs. +// Stringse returns a human readable version of the SequenceIDs. func (s SequenceIDs) String() (humanReadableSequenceIDs string) { result := "SequenceIDs(" firstItem := true From 224808d76aa557115df33e576e313eb30e17a046 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 16:27:12 +0100 Subject: [PATCH 08/13] Refactor: changed bug --- packages/markers/sequence.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 13775144a0..6ddb8611bc 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -353,7 +353,7 @@ func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { return } -// Bytes returns a marshaled version of the SequenceIDs. +// Bytesse returns a marshaled version of the SequenceIDs. func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { marshalUtil := marshalutil.New() marshalUtil.WriteUint32(uint32(len(s))) @@ -364,7 +364,7 @@ func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { return marshalUtil.Bytes() } -// Stringse returns a human readable version of the SequenceIDs. +// String returns a human readable version of the SequenceIDs. func (s SequenceIDs) String() (humanReadableSequenceIDs string) { result := "SequenceIDs(" firstItem := true From 74e5398c5c4202f68de20846a7e1142d54594ea1 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 18:06:25 +0100 Subject: [PATCH 09/13] Refactor: make git fetch more --- .github/workflows/reviewdog.yml | 2 ++ .golangci.yml | 2 +- packages/markers/sequence.go | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 47905f8208..2a3bc96e7e 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -11,6 +11,8 @@ jobs: - name: Checkout repository uses: actions/checkout@v2 + with: + fetch-depth: 0 - uses: actions/setup-go@v2 with: diff --git a/.golangci.yml b/.golangci.yml index b9b056c7ff..af0e3d95ad 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -2,7 +2,7 @@ issues: exclude-use-default: false max-issues-per-linter: 0 max-same-issues: 0 - only-new-issues: true + new-from-rev: e79d2a0c90ae4c80aa56afebcd06d5540bbdc75f # Enhance golangci-lint (#1113) exclude: - 'Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked' # errcheck - 'err113: do not define dynamic errors, use wrapped static errors instead:' # goerr113 diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 6ddb8611bc..8d4efea8a1 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -353,7 +353,7 @@ func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { return } -// Bytesse returns a marshaled version of the SequenceIDs. +// Bytes returns a marshaled version of the SequenceIDs. func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { marshalUtil := marshalutil.New() marshalUtil.WriteUint32(uint32(len(s))) From 8ace1c373489c999cff9530ab5e324a4523545f7 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 18:11:33 +0100 Subject: [PATCH 10/13] Refactor: created error --- packages/markers/sequence.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 8d4efea8a1..34c6f9603c 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -335,7 +335,7 @@ func SequenceIDsFromMarshalUtil(marshalUtil *marshalutil.MarshalUtil) (sequenceI return } -// Alias returns the SequenceAlias of the SequenceIDs. The SequenceAlias is used to address the numerical Sequences +// Aliasse returns the SequenceAlias of the SequenceIDs. The SequenceAlias is used to address the numerical Sequences // in the object storage. func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { sequenceIDsSlice := make([]SequenceID, 0, len(s)) From d8c94b90bdd3ad60d4d5f000b172fb018038666b Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 21:42:16 +0100 Subject: [PATCH 11/13] Fix: fixed settings --- packages/markers/sequence.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index 34c6f9603c..b6684ce70f 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -335,7 +335,7 @@ func SequenceIDsFromMarshalUtil(marshalUtil *marshalutil.MarshalUtil) (sequenceI return } -// Aliasse returns the SequenceAlias of the SequenceIDs. The SequenceAlias is used to address the numerical Sequences +// Alias returns the SequenceAlias of the SequenceIDs. The SequenceAlias is used to address the numerical Sequences // in the object storage. func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { sequenceIDsSlice := make([]SequenceID, 0, len(s)) @@ -353,7 +353,7 @@ func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { return } -// Bytes returns a marshaled version of the SequenceIDs. +// Bytes0sssg returns a marshaled version of the SequenceIDs. func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { marshalUtil := marshalutil.New() marshalUtil.WriteUint32(uint32(len(s))) From c75fa85ed52e1809f8ce6ef6461a3bc6c0c3bcf8 Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 21:58:28 +0100 Subject: [PATCH 12/13] Fix: fixed bug --- packages/markers/sequence.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/markers/sequence.go b/packages/markers/sequence.go index b6684ce70f..8d4efea8a1 100644 --- a/packages/markers/sequence.go +++ b/packages/markers/sequence.go @@ -353,7 +353,7 @@ func (s SequenceIDs) Alias() (aggregatedSequencesID SequenceAlias) { return } -// Bytes0sssg returns a marshaled version of the SequenceIDs. +// Bytes returns a marshaled version of the SequenceIDs. func (s SequenceIDs) Bytes() (marshaledSequenceIDs []byte) { marshalUtil := marshalutil.New() marshalUtil.WriteUint32(uint32(len(s))) From 4472ea201bb19854219b554314ee02be98387cca Mon Sep 17 00:00:00 2001 From: Hans Moog Date: Sat, 27 Mar 2021 22:14:35 +0100 Subject: [PATCH 13/13] Refactor: added comment for option --- .github/workflows/reviewdog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 2a3bc96e7e..d884f5dea6 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -12,7 +12,7 @@ jobs: - name: Checkout repository uses: actions/checkout@v2 with: - fetch-depth: 0 + fetch-depth: 0 # required for new-from-rev option in .golangci.yml - uses: actions/setup-go@v2 with: