Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stencil + Lerna integration #2648

Closed
3 tasks
splitinfinities opened this issue Aug 24, 2020 · 7 comments
Closed
3 tasks

Stencil + Lerna integration #2648

splitinfinities opened this issue Aug 24, 2020 · 7 comments
Labels
Feature: Want this? Upvote it! This PR or Issue may be a great consideration for a future idea.

Comments

@splitinfinities
Copy link
Contributor

splitinfinities commented Aug 24, 2020

Stencil version:

 @stencil/core@2.0.0-6

I'm submitting a:

[x] bug report
[ ] feature request
[ ] support request

Current behavior:
I have two branches on this repo that try to document Lerna integration issues:

Within this repo, I have a small tree: a fake-app component that includes the dependent-component and another-dependent packages, and uses those element in it's render function. The another-dependent has a deep-dependent in it's render function.

Each of these components were made with npm init stencil component component-name, and brought up to spec from 1.17.3 to what 2.0.0-6 asks for.

with the NPM flow right out the gate, it seems the package references the collection, but collection isn't available:
GET http://localhost:3333/another-dependent/dist/collection/components/another-dependent/another-dependent.js net::ERR_ABORTED 404 (Not Found)

Expected behavior:

Through this I found a few issues:

  • The collection entries in package.json will need the same validation treatment that Stencil outputs when main or module are incorrectly set.
  • I looked into the dist folder and only had 3 folders - the component's name, custom-elements, and types. There was no collection folder.
  • ...incoming

I'm going to keep this open for other issues I may find and note my edits.

Steps to reproduce:
For the NPM branch:

  • Check out NPM
  • Do npm run bootstrap && npm run build
  • Run npm start to get the server started.
  • Make edits to any given component, and test changes.

For the Yarn branch:

  • Check out Yarn Workspaces
  • Do yarn bootstrap && yarn build
  • Run yarn start to get the server started.
  • Make edits to any given component, and test changes.

Other information:
You'll notice that only the app pops open in your browser. Look in the stencil.config.ts files for the ports for each individual component, if needed. The packages are imported in the src/index.ts file.

@ionitron-bot ionitron-bot bot added the triage label Aug 24, 2020
@splitinfinities
Copy link
Contributor Author

Edit: fixed "another-component" to be "another-dependent"

@bitflower
Copy link
Contributor

Thanks for putting together this issue!

The same behaviour of dependent packages' changes not being recognized can also be reproduced here:*https://github.com/bitflower/stencil-lerna

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 6, 2022

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Stencil, please create a new issue and ensure the template is fully filled out.

Thank you for using Stencil!

@ionitron-bot ionitron-bot bot closed this as completed Feb 6, 2022
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 6, 2022
@rwaskiewicz
Copy link
Contributor

Reopening, I don't think we want Ionitron closing issues like this. Going to give it some thought as to the best way to implement this

@rwaskiewicz rwaskiewicz reopened this Feb 7, 2022
@ionic-team ionic-team unlocked this conversation Feb 7, 2022
@rwaskiewicz rwaskiewicz added the Feature: Want this? Upvote it! This PR or Issue may be a great consideration for a future idea. label Feb 7, 2022
@bitflower
Copy link
Contributor

Also I think one should probably check for all alternatives or partial solutions like turborepo, yarn workspaces, npm i file: etc.. Maybe more a todo on my aside - anyway a set of example repos showcasing this could help Stencil adoption.

@sardapv
Copy link

sardapv commented Feb 7, 2022

era of lerna is gone. That package has no maintainer since 8 months. Nx has great support with stencil.

@rwaskiewicz rwaskiewicz removed the ionitron: stale issue This issue has not seen any activity for a long period of time label Mar 1, 2022
@rwaskiewicz
Copy link
Contributor

Hey folks 👋

I'm going to be closing this in favor of #1877 to try to consolidate things a bit - please upvote/follow #1877 in lieu of this issue. Thanks!

@rwaskiewicz rwaskiewicz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Want this? Upvote it! This PR or Issue may be a great consideration for a future idea.
Projects
None yet
Development

No branches or pull requests

4 participants