bug: When expose-aside-when is true the menu-close directive should be disabled

[konsultaner]

Type: bug

Platform: all

I'm using the expose-aside-when on the side-menu directive and was wondering why my side-menu would dissapear and leave a gap on the opposite site. The reason was that I was also using the menu-close directive at the same time.

It does the right job, so this is a feature rather then a bug. I cannot see any scenario where a developer would want to close the side menu when it is exposed with expose-aside-when. If for some reason this is the case, then the content should not stay in the reduced width.

[mlynch]

Did this fix it? #2328

[konsultaner]

I fixed it with copying the menu-close directive and fixing it:

['$ionicHistory', '$timeout', function($ionicHistory, $timeout) {
    return {
        restrict: 'AC',
        link: function($scope, $element) {
            $element.bind('click', function() {
                var sideMenuCtrl = $element.inheritedData('$ionSideMenusController');
                if (sideMenuCtrl && !sideMenuCtrl.isAsideExposed()) {
                    $ionicHistory.nextViewOptions({
                        historyRoot: true,
                        disableAnimate: true,
                        expire: 300
                    });
                    $timeout( function() {
                       $ionicHistory.nextViewOptions({
                            historyRoot: false,
                            disableAnimate: false
                        });
                    }, 300);
                    sideMenuCtrl.close();
                 }
            });
        }
    };
}]

[jgw96]

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!