Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: AXE: Elements must use only allowed ARIA attributes for ion-select #22715

Open
kensodemann opened this issue Dec 23, 2020 · 3 comments
Open
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@kensodemann
Copy link
Member

kensodemann commented Dec 23, 2020

Bug Report

Ionic version:

[ ] 4.x
[x] 5.x

Current behavior:
Axe issue - Elements must use only allowed ARIA attributes for ionselect.

Running AXE on the app linked below I get the following for ion-select:

Fix the following:
ARIA attribute is not allowed: aria-required="true"

Expected behavior:
Would be able to use aria-required on an ion-select without the AXE error.

Related code:

https://github.com/ionic-afl/ionic-v5-observations.git

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Dec 23, 2020
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 23, 2020

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!

@kensodemann kensodemann added this to the a11y milestone Dec 23, 2020
@kensodemann
Copy link
Member Author

Discussing with the user, this also results in them not being able to mark the select required in a way that will be properly picked up by a screen reader.

@brandyscarney brandyscarney modified the milestones: a11y, 5.6.0 Feb 18, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report and removed holiday triage issues that were created during holiday period labels Feb 18, 2021
@liamdebeasi liamdebeasi removed this from the 5.6.0 milestone Mar 3, 2021
@kensodemann
Copy link
Member Author

There are issues with the HTML specification itself. aria-required is not something that is allowed, and the spec for custom elements does not allow for a "required" attribute. Thus there is currently no way within the HTML specs to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

3 participants