Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📚] firebase.json processing requires Python2 but requirement is not verified or documented #6194

Closed
ttdatt opened this issue Apr 10, 2022 · 4 comments
Labels
help: good-first-issue Issues that are non-critical issues & well defined for first time contributors. platform: ios plugin: app-core Firebase Apps / Core internals.

Comments

@ttdatt
Copy link

ttdatt commented Apr 10, 2022

Documentation Feedback

This package use python 2 script to encode firebase.json configuration and add that base64 string with the key firebase_json_raw to Info.plist. But Apple will no longer bundle Python 2.7 with macOS 12.3


@ttdatt ttdatt added help: good-first-issue Issues that are non-critical issues & well defined for first time contributors. Type: Docs labels Apr 10, 2022
@ttdatt ttdatt changed the title [📚] Documentation Issue Title - Need to install Python 2 [📚] Need to install Python 2 Apr 10, 2022
@andersonaddo
Copy link
Contributor

You could install it though, no? Is this a blocking issue, or do you think its just something we should add to the docs?

@ttdatt
Copy link
Author

ttdatt commented Apr 15, 2022

You could install it though, no? Is this a blocking issue, or do you think its just something we should add to the docs?

Because from MacOS 12.3, Apple remove Python 2. And like I said react-native-firebase is using Python2 script, the package cannot add configs in firebase.json to Info.plist if python2 doesn't exist. This issue drove me crazy, I have to debug to know why the configuration in firebase.json didn't work. I think you should add Python2 installation in Getting Started or somewhere in the doc.

@mikehardy
Copy link
Collaborator

Whatever part of the system is requiring python should verify existence of python2
The documents should note it

also could a good time to port to python3 really, we're going to have a breaking change release soon probably since it's almost google i/o time and google does them then, might be a good time

Or even better, whatever is happening in python should be ported to javascript since we know we have node available

@mikehardy mikehardy changed the title [📚] Need to install Python 2 [📚] firebase.json processing requires Python2 but requirement is not verified or documented Apr 15, 2022
@mikehardy mikehardy added platform: ios plugin: app-core Firebase Apps / Core internals. labels Apr 15, 2022
@mikehardy
Copy link
Collaborator

I forward ported to python 3 in #6234 and released as v14.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: good-first-issue Issues that are non-critical issues & well defined for first time contributors. platform: ios plugin: app-core Firebase Apps / Core internals.
Projects
None yet
Development

No branches or pull requests

3 participants