Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically migrate to newer GE-Proton #7

Closed
intrand opened this issue Sep 23, 2022 · 8 comments
Closed

automatically migrate to newer GE-Proton #7

intrand opened this issue Sep 23, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@intrand
Copy link
Owner

intrand commented Sep 23, 2022

Ideally, if a game is set to the latest GE-Proton version, and then a new version of GE-Proton is released, the tool should attempt to migrate those games to the newest version. However, if the game is using a version of GE-Proton before that, it's probably set that way for compatibility reasons and the tool shouldn't touch it.

Relies on functionality from #6 being implemented first.

@intrand intrand added the enhancement New feature or request label Sep 23, 2022
@intrand intrand self-assigned this Sep 23, 2022
@intrand
Copy link
Owner Author

intrand commented Sep 24, 2022

Feedback from Reddit: make it optional to migrate from the "previously latest" to the "now latest" version because sometimes new GE-Proton releases can break games that used to work, even in a single update.

Edit: source

@intrand
Copy link
Owner Author

intrand commented Oct 7, 2022

Feedback from Reddit: when someone is without Internet access for a long enough period of time that GloriousEggroll happens to release more than one newer version of GE-Proton, the tool wouldn't be able to distinguish between outdated (eligable for automatic migration) and purposely configured (avoid migrating) compatibility tool settings.

Edit: source

@intrand
Copy link
Owner Author

intrand commented Oct 7, 2022

This feature requires more thought.

Perhaps we could track compatibility tool configuration ourselves, but keeping state in multiple places is prone to bugs/desync. We could duplicate what ProtonUp-Qt has with the ability to migrate games manually, but why not just use that tool then? :)

@krillme
Copy link

krillme commented Mar 19, 2023

Perhaps the tool could not only download the latest version of GE-Proton, but also duplicate it and name the duplicate something like "Latest Version". That way when a game is set to use "Latest Version", every time the tool updates GE-Proton it overwrites "Latest Version" with the most recent version so users don't have to manually configure games to use the latest version every time there's an update. If a game is set to use "Latest Version", it will always be the latest version (as long as you've downloaded it)

@HelmicNewciv
Copy link

HelmicNewciv commented Jun 3, 2023

Couldn't this be handled with a symlink?

Download GE-Proton versions as normal and give them their version name. Create a GE-Proton Latest folder and .acf and what have you, and have that symlinked to whatever the latest version is. Any game that is set to use the latest version will then use whatever the symlink is currently pointing to, and then you can keep a configurable number of rollback versions to keep installed. Once that number is exceeded, delete the oldest versions, not counting those explicitly set as used by a game (so not using GE-Proton Latest). Obviously don't count versions in use by a game towards the rollback limit.

@krillme
Copy link

krillme commented Jun 6, 2023

Yes, that sounds like a more efficient solution than duplicating the files, especially on hardware with limited storage such as the 64 GB Steam Deck.

@intrand
Copy link
Owner Author

intrand commented Jun 24, 2023

Apologies for my silence here - life has been very busy. Having it install an optional "latest" symlink might be a useful feature. I can look at testing this at some point.

Thanks for the feedback!

Also, if you are reading this and know how to write Go code, please feel free to give it a shot and submit a pull request if it looks promising.

@intrand
Copy link
Owner Author

intrand commented Jun 9, 2024

This doesn't seem worth trying to implement as it can break things and has too many edge cases compared to simply using protonup-qt to manage installed versions (it has a migration feature).

@intrand intrand closed this as completed Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants