Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify StringTransformer and RewriteRule #54

Closed
kngenie opened this issue Dec 19, 2014 · 1 comment
Closed

Unify StringTransformer and RewriteRule #54

kngenie opened this issue Dec 19, 2014 · 1 comment
Labels
enhancement

Comments

@kngenie
Copy link
Member

kngenie commented Dec 19, 2014

Wayback has two distinct interfaces for rewriting text resources: StringTransformer and RewriteRule. It'll be useful if we can somehow unify these. At least there's a need for using MultipleRegexReplaceStringTransformer as RewriteRule. First step is to have MultiRegexReplaceStringTransformer implement RewriteRule interface.

Changes are on unify-rewrite branch, and ready to merge into openwayback.
@kngenie
Copy link
Member Author

kngenie commented Jan 19, 2015

Pull request #34.
This change has been merged to iipc/master in 1dbd4f3

@kngenie kngenie closed this as completed Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kngenie