Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signature validation bypass in auth and backend #847

Closed
mkurapov opened this issue Dec 14, 2022 · 1 comment · Fixed by #879
Closed

Remove signature validation bypass in auth and backend #847

mkurapov opened this issue Dec 14, 2022 · 1 comment · Fixed by #879
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Dec 14, 2022

With the new http-signature-utils package (#665 #797), that enables signing requests locally, we can remove the BYPASS_SIGNATURE_VALIDATION flag and it's corresponding config.bypassSignatureValidation checks in the auth and backend packages.

@wilsonianb
Copy link
Contributor

Removing this would allow you to run the backend on its own via

if (
process.env.NODE_ENV !== 'production' &&
token === config.devAccessToken
) {
await next()
return
}

but it would no longer be possible to run a standalone auth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants