Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate payment pointer in Open Payments sub-resource requests #598

Closed
wilsonianb opened this issue Sep 13, 2022 · 0 comments · Fixed by #647
Closed

Validate payment pointer in Open Payments sub-resource requests #598

wilsonianb opened this issue Sep 13, 2022 · 0 comments · Fixed by #647
Assignees
@wilsonianb
Labels
pkg: backend Changes in the backend package. type: security Security related

Comments

@wilsonianb
Copy link
Contributor

Check that a queried sub-resource belongs to the payment pointer of the url, under which grant location the request was authorized.

The paymentPointer is already being added to request ctx. The subsequent sub-resource route method should confirm that the retrieved sub-resources shares the same payment pointer id.

Otherwise for example, someone with a grant to READ outgoing payments for https://wallet.example/bob could access https://wallet.example/alice/outgoing-payments/bf85a520-245c-4398-ae04-f868ffa26eeb by querying https://wallet.example/bob/outgoing-payments/bf85a520-245c-4398-ae04-f868ffa26eeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilsonianb wilsonianb

Labels
pkg: backend Changes in the backend package. type: security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(backend): match subresources by payment pointer interledger/rafiki
1 participant
@wilsonianb