Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quote/outgoing payment to STREAM connection #596

Closed
wilsonianb opened this issue Sep 8, 2022 · 1 comment · Fixed by #603
Closed

Support quote/outgoing payment to STREAM connection #596

wilsonianb opened this issue Sep 8, 2022 · 1 comment · Fixed by #603
Assignees
Labels
pkg: backend Changes in the backend package.

Comments

@wilsonianb
Copy link
Contributor

A quote's specified receiver may be either:

The URL of the incoming payment or ILP STREAM connection that is being paid.

The backend's quote creation currently returns an error if a resolved payment destination is not an incoming payment:

if (!destination.destinationPaymentDetails) {
deps.logger.warn(
{
options
},
'missing incoming payment'
)
throw new Error('missing incoming payment')

@wilsonianb wilsonianb added the pkg: backend Changes in the backend package. label Sep 8, 2022
@wilsonianb wilsonianb added this to Rafiki Sep 8, 2022
@wilsonianb wilsonianb self-assigned this Sep 12, 2022
@wilsonianb
Copy link
Contributor Author

However, after querying an Open Payments connection when attempting to create a fixed-send quote, we are unable to populate the ResolvedPayment's destinationAsset because we do not yet know the receiver's asset details. Pay.setupPayment accomplishes this by performing an asset probe.

Possible workarounds include:

  1. include the receiver's asset details in the /connections/{connectionId} response (the asset of the corresponding incoming payment).
  2. call Pay.setupPayment in Rafiki's Open Payments client service with the connection's destinationAddress and sharedSecret for the sole purpose of performing the asset probe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant