Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /rates API to take in a base parameter #1524

Closed
mkurapov opened this issue Jun 27, 2023 · 0 comments · Fixed by #1527
Closed

Allow /rates API to take in a base parameter #1524

mkurapov opened this issue Jun 27, 2023 · 0 comments · Fixed by #1527
Assignees
Labels
pkg: backend Changes in the backend package. pkg: mock-ase

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Jun 27, 2023

Currently, there is no way for the ASE to specify the base currency for the /rates API.
In the MASE, we are returning an object like:

    {
      base: 'USD',
      rates: {
        EUR: 1.1602,
        ZAR: 17.3792
      }
    }

However, the base would need to be different based on what is passed in the /rates API, eg:
http://cloud-nine-wallet/rates?base=EUR would return

    {
      base: 'EUR',
      rates: {
        USD: 0.8619,
        ZAR: ...
      }
    }

make sure to update the code to the MASE to handle this new parameter as well.

@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Jun 27, 2023
@mkurapov mkurapov moved this from Backlog to Todo in Rafiki Jun 27, 2023
@mkurapov mkurapov added this to the v1.0.0-alpha.3 milestone Jun 27, 2023
@mkurapov mkurapov added pkg: backend Changes in the backend package. pkg: mock-ase labels Jun 27, 2023
@mkurapov mkurapov self-assigned this Jun 28, 2023
@mkurapov mkurapov moved this from Todo to In Progress in Rafiki Jun 28, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Rafiki Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: backend Changes in the backend package. pkg: mock-ase
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant