Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve remaining spelling issues #100

Open
edwarddavidbaker opened this issue Aug 29, 2023 · 6 comments
Open

Resolve remaining spelling issues #100

edwarddavidbaker opened this issue Aug 29, 2023 · 6 comments
Assignees
@edwarddavidbaker

Comments

@edwarddavidbaker
Copy link
Contributor

edwarddavidbaker commented Aug 29, 2023 •
edited
Loading

Currently event lists, TMA spreadsheets, README markdown, and helper scripts contain a few spelling issues. The goal of this issue is to track notes and pull requests.

Related pull requests

Current spelling issues

Event files

Updated 2024-08-01 from 4182336.

./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SRF/metrics/perf/sierraforest_metrics_perf.json: contoller ==> controller
./SRF/metrics/sierraforest_metrics.json: contoller ==> controller
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

Scripting and Additional Documents

./scripts/create_perf_json.py: indentifier ==> identifier
./scripts/create_perf_json.py: seperator ==> separator

./TMA_Metrics-full.csv: Simultanous ==> Simultaneous

./README.md: RECIEVED ==> RECEIVED
@edwarddavidbaker edwarddavidbaker self-assigned this Aug 29, 2023
@edwarddavidbaker
Copy link
Contributor Author

edwarddavidbaker commented Sep 12, 2023 •
edited
Loading

Updating known event spelling issues based on tree at 9d62fc3.

./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./KNL/events/KnightsLanding_core.json: rehad ==> rehab
./KNM/events/KnightsLanding_core.json: rehad ==> rehab
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

@edwarddavidbaker
Copy link
Contributor Author

Updating known event spelling issues based on tree at 7d555c1.

./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

@edwarddavidbaker
Copy link
Contributor Author

Removing TMA section in the summary. All issues were resolved in 20d83ce.

@edwarddavidbaker edwarddavidbaker mentioned this issue Sep 26, 2023
Merged
@edwarddavidbaker
Copy link
Contributor Author

Updating known event spelling issues based on Colin King's suggestions in 37fcb3c.

./BDW-DE/events/broadwellde_uncore.json: filted ==> filtered
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: occpancy ==> occupancy
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDW-DE/events/broadwellde_uncore.json: startved ==> starved, started
./BDX/events/broadwellx_uncore.json: filted ==> filtered
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: occpancy ==> occupancy
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: startved ==> starved, started
./CLX/events/cascadelakex_core.json: michroarchtecture ==> microarchitecture
./CLX/events/cascadelakex_core.json: michroarchitecture ==> microarchitecture
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: Trackes ==> Tracks
./EMR/events/emeraldrapids_uncore_experimental.json: Bouncable ==> Bounceable
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: occpancy ==> occupancy
./HSX/events/haswellx_uncore.json: filted ==> filtered
./HSX/events/haswellx_uncore.json: banwidth ==> bandwidth
./HSX/events/haswellx_uncore.json: servied ==> serviced
./HSX/events/haswellx_uncore.json: Trackes ==> Tracks
./HSX/events/haswellx_uncore.json: startved ==> starved, started
./ICL/events/icelake_core.json: stravation ==> starvation
./ICL/events/icelake_core.json: microarchtecture ==> microarchitecture
./ICX/events/icelakex_core.json: stravation ==> starvation
./ICX/events/icelakex_core.json: microarchtecture ==> microarchitecture
./ICX/events/icelakex_uncore.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: servied ==> serviced
./ICX/events/icelakex_uncore_experimental.json: Trackes ==> Tracks
./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./RKL/events/rocketlake_core.json: stravation ==> starvation
./RKL/events/rocketlake_core.json: microarchtecture ==> microarchitecture
./SKL/events/skylake_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchtecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_uncore.json: trafiic ==> traffic
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SKX/events/skylakex_uncore_experimental.json: Trackes ==> Tracks
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: Trackes ==> Tracks
./SPR/events/sapphirerapids_uncore_experimental.json: Bouncable ==> Bounceable
./TGL/events/tigerlake_core.json: stravation ==> starvation
./TGL/events/tigerlake_core.json: microarchtecture ==> microarchitecture
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

@edwarddavidbaker
Copy link
Contributor Author

Updating based on 5774b4d.

./BDW-DE/events/broadwellde_uncore.json: filted ==> filtered
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: occpancy ==> occupancy
./BDW-DE/events/broadwellde_uncore.json: banwidth ==> bandwidth
./BDW-DE/events/broadwellde_uncore.json: servied ==> serviced
./BDW-DE/events/broadwellde_uncore.json: startved ==> starved, started
./BDX/events/broadwellx_uncore.json: filted ==> filtered
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: occpancy ==> occupancy
./BDX/events/broadwellx_uncore.json: banwidth ==> bandwidth
./BDX/events/broadwellx_uncore.json: servied ==> serviced
./BDX/events/broadwellx_uncore.json: startved ==> starved, started
./CLX/events/cascadelakex_core.json: michroarchtecture ==> microarchitecture
./CLX/events/cascadelakex_core.json: michroarchitecture ==> microarchitecture
./CLX/events/cascadelakex_uncore_experimental.json: servied ==> serviced
./CLX/events/cascadelakex_uncore_experimental.json: Trackes ==> Tracks
./HSW/events/haswell_core.json: inflight ==> in-flight
./HSX/events/haswellx_core.json: inflight ==> in-flight
./HSX/events/haswellx_uncore.json: occpancy ==> occupancy
./HSX/events/haswellx_uncore.json: filted ==> filtered
./HSX/events/haswellx_uncore.json: banwidth ==> bandwidth
./HSX/events/haswellx_uncore.json: servied ==> serviced
./HSX/events/haswellx_uncore.json: Trackes ==> Tracks
./HSX/events/haswellx_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: Thereofore ==> Therefore
./IVT/events/ivytown_uncore.json: filted ==> filtered
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: occpancy ==> occupancy
./IVT/events/ivytown_uncore.json: banwidth ==> bandwidth
./IVT/events/ivytown_uncore.json: startved ==> starved, started
./IVT/events/ivytown_uncore.json: occuapancy ==> occupancy
./IVT/events/ivytown_uncore.json: Trackes ==> Tracks
./JKT/events/Jaketown_core.json: reqisters ==> registers
./JKT/events/Jaketown_core.json: pipeilne ==> pipeline
./JKT/events/Jaketown_core.json: unchacheable ==> uncacheable
./JKT/events/Jaketown_uncore.json: Thereofore ==> Therefore
./JKT/events/Jaketown_uncore.json: filted ==> filtered
./JKT/events/Jaketown_uncore.json: banwidth ==> bandwidth
./JKT/events/Jaketown_uncore.json: occuapancy ==> occupancy
./NHM-EP/events/NehalemEP_core.json: Prediciton ==> Prediction
./NHM-EX/events/NehalemEX_core.json: Prediciton ==> Prediction
./SKX/events/skylakex_core.json: michroarchtecture ==> microarchitecture
./SKX/events/skylakex_core.json: michroarchitecture ==> microarchitecture
./SKX/events/skylakex_uncore.json: trafiic ==> traffic
./SKX/events/skylakex_uncore_experimental.json: servied ==> serviced
./SKX/events/skylakex_uncore_experimental.json: Trackes ==> Tracks
./SNB/events/sandybridge_core.json: reqisters ==> registers
./SNB/events/sandybridge_core.json: unchacheable ==> uncacheable
./SNB/events/sandybridge_core.json: pipeilne ==> pipeline
./SNR/events/snowridgex_uncore.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: servied ==> serviced
./SNR/events/snowridgex_uncore_experimental.json: Trackes ==> Tracks
./TMA_Metrics-full.csv: Simultanous ==> Simultaneous
./WSM-EP-DP/events/WestmereEP-DP_core.json: Prediciton ==> Prediction
./WSM-EP-SP/events/WestmereEP-SP_core.json: Prediciton ==> Prediction

@steguerrini
Copy link

A minor error can be found in "For tool developers" in the spreadsheet:

E.g. if a Node := A / B with Metric Max of 1.0, the final value should be Node = max(1, A/B).

I think it should be

E.g. if a Node := A / B with Metric Max of 1.0, the final value should be Node = min(1, A/B).

@edwarddavidbaker edwarddavidbaker mentioned this issue Aug 1, 2024
Open
@edwarddavidbaker edwarddavidbaker mentioned this issue Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwarddavidbaker edwarddavidbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edwarddavidbaker @steguerrini