Can we drop target triple environment component -sycldevice
?
#3534
Labels
enhancement
New feature or request
upstream
This change is related to upstreaming SYCL support to llorg.
One of the use cases for this target triple component is configuring SPIR target address space map.
During discussion in https://reviews.llvm.org/D89909 comments we decided to implement a different approach, which doesn't require adding environment component for SYCL.
I'd like to gather to all existing use cases for
-sycldevice
and check if it's really necessary.Use cases:
NVPTXWe have two passes added in llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp to process GlobalOffset and Local accessors. These are added to the pipeline only if module hassycldevice
environment component. @Naghasan, would be safe to enable them by default?NVPTX target configures TLSSupported for SYCL. We should be able to overloadDone by [SYCL][NVPTX][NFC] Refactor NVPTX target configuration #3535.adjust
member function and uses language option for configuration.-sycldevice
to work around for [SYCL][Driver] fsycl-device-only does not offload, target triple is used to define programing model #1814. TODO: check if we can remove the hack as [SYCL][Driver] fsycl-device-only does not offload, target triple is used to define programing model #1814 is fixed.-sycldevice
component is checked and I hope we can replace all these checks with the language mode check i.e. if-fsycl-[device,host]-only
mode is set. @mdtoguchi, can we do this?-sycldevice
, but we need to check if it's the case for other targets as well (e.g. NVPTX, Xilinx, Intel FPGA, ???).The text was updated successfully, but these errors were encountered: