Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebased #96: Create repos for non-organizations #322

Conversation

abitrolly
Copy link

This needs a thorough review. I just rebased the changes to make them mergeable and solved conflicts without digging too much into how GitHub provider currently handles all parameters. Especially func (c *Config) Client() seem wrong to me.

@ghost ghost added the size/XL label Jan 16, 2020
@abitrolly abitrolly mentioned this pull request Jan 16, 2020
@anGie44
Copy link
Contributor

anGie44 commented Apr 16, 2020

thank you @abitrolly for this rebase! if you plan on contributing more to this work please note i've similarly taken the original PR https://github.com/terraform-providers/terraform-provider-github/pull/96 and merged w/the current state of master to create this WIP PR https://github.com/terraform-providers/terraform-provider-github/pull/428.

@abitrolly
Copy link
Author

@anGie44 tests in #428 still do not pass.

@anGie44
Copy link
Contributor

anGie44 commented Apr 17, 2020

ah yes @abitrolly, good catch! I think an addition to these 2 files should help in the tests that look for the new GITHUB_BASE_URL -- in addition to making that var available in acceptance-tests.yml

@abitrolly
Copy link
Author

#428 is deprecated and now the progress is being done in https://github.com/terraform-providers/terraform-provider-github/milestone/8

@abitrolly
Copy link
Author

Superseded by #464 and #465.

@abitrolly abitrolly closed this Jun 19, 2020
@abitrolly abitrolly deleted the eliaszs/feature/individual_account branch March 31, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants