Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger phase regex is overly restrictive #4

Closed
axelson opened this issue Oct 7, 2020 · 3 comments
Closed

Trigger phase regex is overly restrictive #4

axelson opened this issue Oct 7, 2020 · 3 comments

Comments

@axelson
Copy link

axelson commented Oct 7, 2020

It looks like the regex requires ** around the trigger phrase. However that requirement is not documented at all and seems like it could be removed.
@iamalisajid
Copy link
Collaborator

Thanks for logging the issue @axelson will definitely make a quick fix soon.

@axelson
Copy link
Author

axelson commented Oct 13, 2020

Thank you!

@iamalisajid iamalisajid mentioned this issue Oct 20, 2020
Merged
@iamalisajid
Copy link
Collaborator

Fixed in release 1.0.1
Details: https://github.com/insurify/github-asana-action/releases/tag/v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axelson @iamalisajid