Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misnamed applications: document and migrate #110

Open
1 of 3 tasks
bcardiff opened this issue Jul 18, 2016 · 3 comments
Open
1 of 3 tasks

Fix misnamed applications: document and migrate #110

bcardiff opened this issue Jul 18, 2016 · 3 comments
Labels

Comments

@bcardiff
Copy link

bcardiff commented Jul 18, 2016

There are some misnamed applications currently: verboice-cdc-cambodia, verboice-cambodia, (empty).

  • Document that Application value should no be changed upon deployment.
  • Contact ilab team to fix the following application names
    • verboice-cdc-cambodia -> verboice-cdc
    • verboice-cambodia -> verboice
  • Migrate data
    • verboice-cdc-cambodia -> verboice-cdc ?
    • verboice-cambodia -> verboice
    • (empty) -> Resourcemap WFP Production

The (empty) application seems to have been renamed since it was created. So it might be the case that there is some data to remove or migrate.

@nditada nditada added the ready label Jul 18, 2016
@bcardiff
Copy link
Author

  • verboice-cambodia uuid abc5111b-eeeb-494b-b893-a9236fa74ab0
  • verboice-cdc-cambodia uuid f50bc6f9-db0e-49d0-9c58-795c9b068194
  • (empty)/Resourcemap WFP Production uuid 59af642d-2092-416b-b59e-38c237fe1dfd
  • verboice.com 3385bff4-0d41-4ee7-b345-eb8250ff949a

@bcardiff
Copy link
Author

I think telemetry server should have a way to override the application name and that override the application name that is indexed on each metric. We might could have no ownership on the installation configuration so the ultimate solution is to override this.

Overriding the application name could trigger a reindex of the event. While we wait for configuration updates we could work on allowing overrides on our side.

Also, event can be sent with an application application name different from the initial configured app name. This leads to inconsistency of indexed metrics. Installation name should override event data and not the other way around.

Proposal:

  1. Store initial and last known installation name in reported_name field (ie. rename current name field)
  2. Update reported_name on each event sent to the server.
  3. Add overrided_name field editable from the UI in a details view of the installation (where the reported name is also shown)
  4. Define name as overrided_name || reported_name and use this for listings and indexing event.
  5. Reindex all events when the effective name is updated.

@nditada / @waj thoughts?

@nditada
Copy link

nditada commented Jul 27, 2016

This sounds like a very complete and solid solution @bcardiff, and it would allow us to decouple 'showing good aggregates' from 'having others fix their installations'. My only concern would be effort required. If this is less than 40hs, go ahead, if not, let's talk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants