From 7a6974269dd8dd35e4bcee95a057d4e981fbad31 Mon Sep 17 00:00:00 2001
From: Matias Garcia Isaia <mgarcia@manas.tech>
Date: Wed, 8 Mar 2017 18:59:53 -0300
Subject: [PATCH] 'Select one' fields in single-edit mode

The `notifyEdit` handler has been added in 2d7ba16676e8e731859a964af20ab48b54bec96b
to correctly activate single-edition mode while clicking on the
field's rows. But that handler was preventing the click event to
reach the `<select>` element, and thus avoided showing the options
- ie, it couldn't be edited.

Removing the listener seems to fix the Select one edition, and it
doesn't seem to break the row-click for any of the existent field
types.

Fixes #875
---
 app/assets/javascripts/collections/field.coffee | 6 ------
 app/views/collections/index/_map.haml           | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/app/assets/javascripts/collections/field.coffee b/app/assets/javascripts/collections/field.coffee
index 93bcfd0b9..800622ac4 100644
--- a/app/assets/javascripts/collections/field.coffee
+++ b/app/assets/javascripts/collections/field.coffee
@@ -202,12 +202,6 @@ onCollections ->
       window.model.initDatePicker(optionsDatePicker)
       window.model.initAutocomplete()
 
-    notifyEdit: (ev) =>
-      # TODO: remove this eventually; this handler exists only to be installed
-      # as the mousedown handler for the field's row DIV. Otherwise, there are
-      # situations when clicking on the row doesn't activate the edition
-      undefined
-
     keyPress: (field, event) =>
       switch event.keyCode
         when 13 then @save()
diff --git a/app/views/collections/index/_map.haml b/app/views/collections/index/_map.haml
index 9b06cf62d..270e5ad46 100644
--- a/app/views/collections/index/_map.haml
+++ b/app/views/collections/index/_map.haml
@@ -204,7 +204,7 @@
               /ko if: writeable
               /- TODO: remove the mousedown handler. Otherwise, there are
               /- situations when clicking on the row doesn't activate the edition
-              %div.site_row.writeable{ko(click: 'edit', event: {mousedown: 'notifyEdit'})}
+              %div.site_row.writeable{ko(click: 'edit')}
                 %span{ko(text: :errorMessage, validationPopover: :errorMessage), style: 'display: none;'}
                 %label.field-name{ko(text: "name + ':'", topPopover: "__('Field Code') + ': ' + code", css: { error: :error })}
                 /ko if: hasValue() && !error()