-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Magpie 2.0 #117
Release Magpie 2.0 #117
Conversation
so how are things looking @kaplun ? :) |
Ahem! I forgot about it, and today was fully away at a course. And tomorrow will also away... d'oh! |
no rush, take a look when you have some free time :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (I trust you for the NN part!)
@inspirehep/core anyone with experience in NN wants to have a second look? |
So purely from a user's perspective: All I have to do to start using the shiny new Magpie 2.0 is:
and thats it? No changes to Magpie's output (like when Magpie switched to top-k accuracy, the indexes in the Keras callback changed) by switching to a new Keras version? Perhaps this information could be added to the README for I think a simple summation of changes that have to be made should suffice, adding a new chapter below the chapter about differences between v1 and v2. Perhaps something like: Migrating from Magpie v1.0 to v2.0
|
@NowayIndustries Yes, that's pretty much it. I intend to create a GitHub release and describe all the changes there, but perhaps adding another paragraph to the README is also a sensible idea. |
@NowayIndustries if you intend to migrate, let me know how the new version works for you! |
@jstypka Unless anything else pops up I'll probably be working on migrating to the new version next Thursday/Friday. Hopefully it wll indeed be as simple as those small changes, I'll let you know either way. |
So as it turns out it is that simple, just follow the 3 simple steps and you're done. One small caveat though, you can't load saved v1 models into v2 (not that you'd really want to in any normal case, but my API around Magpie autoloads the files if found). I'm currently running a copy of production with v2 as production (with the models retrained obviously) and so far so good. Training & prediction both work fine and predicted labels seem relevant and at least similar (if not identical) to the v1 variant (of course including some wiggle room for differences between training sessions). So 🎉 congratulations 🎉, it just works (TM). For completeness sake:
pip freeze
I had to modify a grand total of 12 lines in order to apply these changes, of which 7 were documentation changes ;) |
Awesome @NowayIndustries, thanks for the heads up! Let us know if you also see any discrepancies in terms of accuracy, both drop and an increase - that would be interesting. @kaplun I don't know what state is Magpie at the model in production at CERN, but the incompatibility between the models is worth noting. |
As mentioned before (in #97), Keras 2.0 that Magpie depends on introduced some breaking changes, so in order to keep up to date with it, we need to release a new version of Magpie.
There are no changes to functionality, only updates to the API so it works with new Keras. I also took advantage to change the main object name from
MagpieModel
toMagpie
which I wanted to do for a long time. These are breaking changes, therefore we release them under v2.0. Version 1.0 is tagged and can still be installed from GHE.Changes:
MagpieModel
->Magpie
as a name of the main objectnb_epochs
->epochs
as in the new Kerasbatch_train()
function, which now takes in the number of batches and not the number of samplesbatch_train()
that uses an RNNsetup.py
to 2.0 🍾@kaplun