Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FinalizeBlock Response Deserialization Bug #1427

Closed
ec2 opened this issue May 24, 2024 · 0 comments · Fixed by #1428
Closed

FinalizeBlock Response Deserialization Bug #1427

ec2 opened this issue May 24, 2024 · 0 comments · Fixed by #1428
Labels
bug Something isn't working

Comments

@ec2
Copy link
Contributor

ec2 commented May 24, 2024

What went wrong?

CometBFT returns Null in the JSON response if there is no validator_updates.
Proposed Fix: Add #[serde(with = "serializers::nullable")] to validator_updates just like how EndBlock has it

Steps to reproduce

Definition of "done"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tendermint): Make FinalizeBlock::validator_updates nullable when deserializing ec2/tendermint-rs
1 participant
@ec2